Page MenuHomePhabricator
Differential D14092

[lib] include embeds in neynar client's postCast method
ClosedPublic
Actions

Authored by will on Dec 6 2024, 8:26 PM.
Tags
None
Referenced Files
F6058291: D14092.id46265.diff
Sun, Apr 20, 7:43 AM
Unknown Object (File)
Wed, Apr 16, 4:42 PM
Unknown Object (File)
Thu, Apr 3, 2:44 AM
Unknown Object (File)
Mar 15 2025, 1:40 AM
Unknown Object (File)
Mar 15 2025, 1:40 AM
Unknown Object (File)
Mar 15 2025, 1:40 AM
Unknown Object (File)
Mar 15 2025, 1:40 AM
Unknown Object (File)
Mar 15 2025, 1:40 AM
View All 96 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMMd2804563a8f1: [lib] include embeds in neynar client's postCast method
Summary

This adds embeds as a parameter to the postCast method for the neynar client and makes text optional

Depends on D14086

Test Plan

Tested later in the stack. Was able to successfully post the frame url to warpcast

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Dec 6 2024, 8:26 PM
Herald added a subscriber: tomek. · View Herald TranscriptDec 6 2024, 8:26 PM
will edited the summary of this revision. (Show Details)Dec 6 2024, 8:26 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 6 2024, 8:45 PM
Harbormaster failed remote builds in B32959: Diff 46253!
will updated this revision to Diff 46256.Dec 6 2024, 8:59 PM

fix missing parameter

Harbormaster completed remote builds in B32961: Diff 46256.Dec 6 2024, 9:17 PM
will requested review of this revision.Dec 6 2024, 9:17 PM
will added inline comments.Dec 7 2024, 8:28 AM
keyserver/src/responders/farcaster-webhook-responders.js
326–331 ↗(On Diff #46256)

Unsure if including undefined as an argument here is fine. The text parameter for postCast is optional. I found another example of us doing this in a call to persistCryptoStore in web/shared-worker/worker/worker-crypto.js:

await persistCryptoStore(undefined, true);
will added a parent revision: D14093: [keyserver] replace farcaster bot reply text with frame.Dec 7 2024, 8:49 AM
will edited the summary of this revision. (Show Details)
will edited the summary of this revision. (Show Details)
will removed a parent revision: D14093: [keyserver] replace farcaster bot reply text with frame.
will added a child revision: D14093: [keyserver] replace farcaster bot reply text with frame.
ashoat accepted this revision.Dec 8 2024, 8:10 PM
ashoat added inline comments.
lib/utils/neynar-client.js
349–352 ↗(On Diff #46256)

Can we turn this into a "bag of params" instead? (Basically have it take one param, which is an object that can contain four properties)

async postCast(
  params: {
    +signerUUID: string,
    +parent: string,
    +embeds?: ?$ReadOnlyArray<{ +url: string }>,
    +text?: ?string,
  }
): Promise<NeynarPostCastResponse> {
351 ↗(On Diff #46256)

You're missing a +

This revision is now accepted and ready to land.Dec 8 2024, 8:10 PM
will added inline comments.Dec 9 2024, 6:40 AM
keyserver/src/responders/farcaster-webhook-responders.js
326–331 ↗(On Diff #46256)

This will get addressed by the bag of params approach outlined below. Including in next rebase

lib/utils/neynar-client.js
349–352 ↗(On Diff #46256)

Yeah. Unsure if we have a strict coding standard but it sounds like whenever we have four or more parameters for a function (or optional parameters), we should consider using a bag of params. Makes it easier to read function calls

I'll include this in the next rebase

ashoat added inline comments.Dec 9 2024, 8:26 AM
lib/utils/neynar-client.js
349–352 ↗(On Diff #46256)

No strict rules, but 4 is a good guideline

will updated this revision to Diff 46265.Dec 9 2024, 1:44 PM
will edited the summary of this revision. (Show Details)

rebase

Harbormaster completed remote builds in B32969: Diff 46265.Dec 9 2024, 2:09 PM
will updated this revision to Diff 46270.Dec 9 2024, 3:07 PM

fix setting parent

Harbormaster completed remote builds in B32974: Diff 46270.Dec 9 2024, 3:26 PM
Closed by commit rCOMMd2804563a8f1: [lib] include embeds in neynar client's postCast method (authored by will). · Explain WhyDec 9 2024, 4:56 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMd2804563a8f1: [lib] include embeds in neynar client's postCast method.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
10 lines
lib/
utils/
30 lines

Diff 46282

View Options

keyserver/src/responders/farcaster-webhook-responders.js

Show All 21 Lines
import { SafeAreaView } from 'react-native-safe-area-context'; import { SafeAreaView } from 'react-native-safe-area-context';
import { useIsLoggedInToAuthoritativeKeyserver } from 'lib/hooks/account-hooks.js'; import { useIsLoggedInToAuthoritativeKeyserver } from 'lib/hooks/account-hooks.js';
import { setActiveSessionRecoveryActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setActiveSessionRecoveryActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { usePersistedStateLoaded } from 'lib/selectors/app-state-selectors.js'; import { usePersistedStateLoaded } from 'lib/selectors/app-state-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { recoveryFromReduxActionSources } from 'lib/types/account-types.js'; import { recoveryFromReduxActionSources } from 'lib/types/account-types.js';
import { useDispatch } from 'lib/utils/redux-utils.js'; import { useDispatch } from 'lib/utils/redux-utils.js';
import { usingCommServicesAccessToken } from 'lib/utils/services-utils.js'; import {
usingCommServicesAccessToken,
usingRestoreFlow,
} from 'lib/utils/services-utils.js';
import { splashBackgroundURI } from './background-info.js'; import { splashBackgroundURI } from './background-info.js';
import FullscreenSIWEPanel from './fullscreen-siwe-panel.react.js'; import FullscreenSIWEPanel from './fullscreen-siwe-panel.react.js';
import LogInPanel from './log-in-panel.react.js'; import LogInPanel from './log-in-panel.react.js';
import type { LogInState } from './log-in-panel.react.js'; import type { LogInState } from './log-in-panel.react.js';
import LoggedOutStaffInfo from './logged-out-staff-info.react.js'; import LoggedOutStaffInfo from './logged-out-staff-info.react.js';
import { authoritativeKeyserverID } from '../authoritative-keyserver.js'; import { authoritativeKeyserverID } from '../authoritative-keyserver.js';
import KeyboardAvoidingView from '../components/keyboard-avoiding-view.react.js'; import KeyboardAvoidingView from '../components/keyboard-avoiding-view.react.js';
▲ Show 20 Lines • Show All 452 Lines • ▼ Show 20 Lines const buttonsViewStyle = React.useMemo(
[styles.buttonContainer, buttonsViewOpacity], [styles.buttonContainer, buttonsViewOpacity],
); );
const buttons = React.useMemo(() => { const buttons = React.useMemo(() => {
if (mode.curMode !== 'prompt') { if (mode.curMode !== 'prompt') {
return null; return null;
} }
const signInButtons = []; const signInButtons = [];
if (!usingRestoreFlow) {
signInButtons.push( signInButtons.push(
<TouchableOpacity <TouchableOpacity
onPress={onPressLogIn} onPress={onPressLogIn}
style={classicAuthButtonStyle} style={classicAuthButtonStyle}
activeOpacity={0.6} activeOpacity={0.6}
key="login-form" key="login-form"
> >
<Text style={classicAuthButtonTextStyle}>Sign in</Text> <Text style={classicAuthButtonTextStyle}>Sign in</Text>
</TouchableOpacity>, </TouchableOpacity>,
); );
if (__DEV__) { }
if (__DEV__ || usingRestoreFlow) {
const buttonText = usingRestoreFlow ? 'Sign in' : 'Sign in (QR)';
signInButtons.push( signInButtons.push(
<TouchableOpacity <TouchableOpacity
onPress={onPressQRCodeSignIn} onPress={onPressQRCodeSignIn}
style={classicAuthButtonStyle} style={classicAuthButtonStyle}
activeOpacity={0.6} activeOpacity={0.6}
key="qr-code-login" key="qr-code-login"
> >
<Text style={classicAuthButtonTextStyle}>Sign in (QR)</Text> <Text style={classicAuthButtonTextStyle}>{buttonText}</Text>
</TouchableOpacity>, </TouchableOpacity>,
); );
} }
return ( let siweSection = null;
<AnimatedView style={buttonsViewStyle}> if (!usingRestoreFlow) {
<LoggedOutStaffInfo /> siweSection = (
<>
<TouchableOpacity <TouchableOpacity
onPress={onPressSIWE} onPress={onPressSIWE}
style={siweAuthButtonStyle} style={siweAuthButtonStyle}
activeOpacity={0.6} activeOpacity={0.6}
> >
<View style={styles.siweIcon}> <View style={styles.siweIcon}>
<EthereumLogo /> <EthereumLogo />
</View> </View>
<Text style={siweAuthButtonTextStyle}>Sign in with Ethereum</Text> <Text style={siweAuthButtonTextStyle}>Sign in with Ethereum</Text>
</TouchableOpacity> </TouchableOpacity>
<View style={styles.siweOr}> <View style={styles.siweOr}>
<View style={styles.siweOrLeftHR} /> <View style={styles.siweOrLeftHR} />
<Text style={styles.siweOrText}>or</Text> <Text style={styles.siweOrText}>or</Text>
<View style={styles.siweOrRightHR} /> <View style={styles.siweOrRightHR} />
</View> </View>
</>
);
}
return (
<AnimatedView style={buttonsViewStyle}>
<LoggedOutStaffInfo />
{siweSection}
<View style={styles.signInButtons}>{signInButtons}</View> <View style={styles.signInButtons}>{signInButtons}</View>
<View style={styles.registerButtons}> <View style={styles.registerButtons}>
<TouchableOpacity <TouchableOpacity
onPress={onPressNewRegister} onPress={onPressNewRegister}
style={classicAuthButtonStyle} style={classicAuthButtonStyle}
activeOpacity={0.6} activeOpacity={0.6}
key="new" key="new"
> >
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines
View Options

lib/utils/neynar-client.js

Show All 21 Lines
import { SafeAreaView } from 'react-native-safe-area-context'; import { SafeAreaView } from 'react-native-safe-area-context';
import { useIsLoggedInToAuthoritativeKeyserver } from 'lib/hooks/account-hooks.js'; import { useIsLoggedInToAuthoritativeKeyserver } from 'lib/hooks/account-hooks.js';
import { setActiveSessionRecoveryActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setActiveSessionRecoveryActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { usePersistedStateLoaded } from 'lib/selectors/app-state-selectors.js'; import { usePersistedStateLoaded } from 'lib/selectors/app-state-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { recoveryFromReduxActionSources } from 'lib/types/account-types.js'; import { recoveryFromReduxActionSources } from 'lib/types/account-types.js';
import { useDispatch } from 'lib/utils/redux-utils.js'; import { useDispatch } from 'lib/utils/redux-utils.js';
import { usingCommServicesAccessToken } from 'lib/utils/services-utils.js'; import {
usingCommServicesAccessToken,
usingRestoreFlow,
} from 'lib/utils/services-utils.js';
import { splashBackgroundURI } from './background-info.js'; import { splashBackgroundURI } from './background-info.js';
import FullscreenSIWEPanel from './fullscreen-siwe-panel.react.js'; import FullscreenSIWEPanel from './fullscreen-siwe-panel.react.js';
import LogInPanel from './log-in-panel.react.js'; import LogInPanel from './log-in-panel.react.js';
import type { LogInState } from './log-in-panel.react.js'; import type { LogInState } from './log-in-panel.react.js';
import LoggedOutStaffInfo from './logged-out-staff-info.react.js'; import LoggedOutStaffInfo from './logged-out-staff-info.react.js';
import { authoritativeKeyserverID } from '../authoritative-keyserver.js'; import { authoritativeKeyserverID } from '../authoritative-keyserver.js';
import KeyboardAvoidingView from '../components/keyboard-avoiding-view.react.js'; import KeyboardAvoidingView from '../components/keyboard-avoiding-view.react.js';
▲ Show 20 Lines • Show All 452 Lines • ▼ Show 20 Lines const buttonsViewStyle = React.useMemo(
[styles.buttonContainer, buttonsViewOpacity], [styles.buttonContainer, buttonsViewOpacity],
); );
const buttons = React.useMemo(() => { const buttons = React.useMemo(() => {
if (mode.curMode !== 'prompt') { if (mode.curMode !== 'prompt') {
return null; return null;
} }
const signInButtons = []; const signInButtons = [];
if (!usingRestoreFlow) {
signInButtons.push( signInButtons.push(
<TouchableOpacity <TouchableOpacity
onPress={onPressLogIn} onPress={onPressLogIn}
style={classicAuthButtonStyle} style={classicAuthButtonStyle}
activeOpacity={0.6} activeOpacity={0.6}
key="login-form" key="login-form"
> >
<Text style={classicAuthButtonTextStyle}>Sign in</Text> <Text style={classicAuthButtonTextStyle}>Sign in</Text>
</TouchableOpacity>, </TouchableOpacity>,
); );
if (__DEV__) { }
if (__DEV__ || usingRestoreFlow) {
const buttonText = usingRestoreFlow ? 'Sign in' : 'Sign in (QR)';
signInButtons.push( signInButtons.push(
<TouchableOpacity <TouchableOpacity
onPress={onPressQRCodeSignIn} onPress={onPressQRCodeSignIn}
style={classicAuthButtonStyle} style={classicAuthButtonStyle}
activeOpacity={0.6} activeOpacity={0.6}
key="qr-code-login" key="qr-code-login"
> >
<Text style={classicAuthButtonTextStyle}>Sign in (QR)</Text> <Text style={classicAuthButtonTextStyle}>{buttonText}</Text>
</TouchableOpacity>, </TouchableOpacity>,
); );
} }
return ( let siweSection = null;
<AnimatedView style={buttonsViewStyle}> if (!usingRestoreFlow) {
<LoggedOutStaffInfo /> siweSection = (
<>
<TouchableOpacity <TouchableOpacity
onPress={onPressSIWE} onPress={onPressSIWE}
style={siweAuthButtonStyle} style={siweAuthButtonStyle}
activeOpacity={0.6} activeOpacity={0.6}
> >
<View style={styles.siweIcon}> <View style={styles.siweIcon}>
<EthereumLogo /> <EthereumLogo />
</View> </View>
<Text style={siweAuthButtonTextStyle}>Sign in with Ethereum</Text> <Text style={siweAuthButtonTextStyle}>Sign in with Ethereum</Text>
</TouchableOpacity> </TouchableOpacity>
<View style={styles.siweOr}> <View style={styles.siweOr}>
<View style={styles.siweOrLeftHR} /> <View style={styles.siweOrLeftHR} />
<Text style={styles.siweOrText}>or</Text> <Text style={styles.siweOrText}>or</Text>
<View style={styles.siweOrRightHR} /> <View style={styles.siweOrRightHR} />
</View> </View>
</>
);
}
return (
<AnimatedView style={buttonsViewStyle}>
<LoggedOutStaffInfo />
{siweSection}
<View style={styles.signInButtons}>{signInButtons}</View> <View style={styles.signInButtons}>{signInButtons}</View>
<View style={styles.registerButtons}> <View style={styles.registerButtons}>
<TouchableOpacity <TouchableOpacity
onPress={onPressNewRegister} onPress={onPressNewRegister}
style={classicAuthButtonStyle} style={classicAuthButtonStyle}
activeOpacity={0.6} activeOpacity={0.6}
key="new" key="new"
> >
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines