Page MenuHomePhabricator
Differential D13947

[keyserver] frog hello world example
Needs RevisionPublic
Actions

Authored by will on Fri, Nov 15, 12:06 PM.

Details

Reviewers
ashoat
Summary

This diff implements a hello world Frog application and serves it on port 3001.

Depends on D13927

Test Plan

GET requests to the keyserver at localhost:3001 contain valid HTML document in the response.

Used ngrok to create a publicly accessible url forwarding requests to locahost:3001. Used this url to validate the frame with the warpcast frame validator at https://warpcast.com/~/developers/frames?url=https://81fb-69-201-171-11.ngrok-free.app

Diff Detail

Repository
rCOMM Comm
Branch
wyilio/frames
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Fri, Nov 15, 12:06 PM
Herald added a subscriber: tomek. · View Herald TranscriptFri, Nov 15, 12:07 PM
will edited the summary of this revision. (Show Details)Fri, Nov 15, 12:07 PM
will added a parent revision: D13927: [keyserver] Have @babel/preset-react use automatic runtime.
will added inline comments.
keyserver/src/frog/frog.js
13–22

The JSX here will be replaced later in the stack. This is a placeholder

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Nov 15, 1:30 PM
Harbormaster failed remote builds in B32687: Diff 45850!
Harbormaster completed remote builds in B32687: Diff 45850.Fri, Nov 15, 1:56 PM
will requested review of this revision.Fri, Nov 15, 1:56 PM
ashoat added inline comments.Fri, Nov 15, 2:02 PM
keyserver/.eslintrc.json
13

We talked about doing this via a // eslint-disable macro... why'd you decide against it?

ashoat requested changes to this revision.Fri, Nov 15, 2:03 PM

Back to you with question

This revision now requires changes to proceed.Fri, Nov 15, 2:03 PM

Revision Contents
Changeset List

PathSize
keyserver/
10 lines
flow-typed/
npm/
@hono/
13 lines
38 lines
src/
frog/
32 lines
3 lines

Diff 45850

View Options

keyserver/.eslintrc.json

Loading...
View Options

keyserver/flow-typed/npm/@hono/node-server_vx.x.x.js

Loading...
View Options

keyserver/flow-typed/npm/frog_v0.18.x.js

Loading...
View Options

keyserver/src/frog/frog.js

Loading...
View Options

keyserver/src/keyserver.js

Loading...