Page MenuHomePhabricator
Differential D13999

[keyserver] use default channel cover image stored on in keyserver/images in frame
Needs ReviewPublic
Actions

Authored by will on Thu, Nov 21, 11:37 PM.

Details

Reviewers
ashoat
varun
Summary

Instead of using the link to the warpcast's default channel cover image, we store it on the keyserver and serve it at a frog hono route to be used by the frame's `<img /> JSX element as the src

Depends on D13998

Test Plan

Verified on the warpcast frame validator and confirmed that specifying a channel with no custom channel cover still resolved to the same default cover image

image.png (960×1 px, 439 KB)

Diff Detail

Repository
rCOMM Comm
Branch
wyilio/frames
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Thu, Nov 21, 11:37 PM
Herald added a subscriber: tomek. · View Herald TranscriptThu, Nov 21, 11:37 PM
will edited the test plan for this revision. (Show Details)Thu, Nov 21, 11:37 PM
will edited the test plan for this revision. (Show Details)
will edited the summary of this revision. (Show Details)
will edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B32760: Diff 45936.Thu, Nov 21, 11:53 PM
will requested review of this revision.Thu, Nov 21, 11:53 PM

Revision Contents
Changeset List

PathSize
keyserver/
flow-typed/
npm/
@hono/
12 lines
2 lines
15 lines
images/
src/
frog/
10 lines

Diff 45936

View Options

keyserver/flow-typed/npm/@hono/node-server_vx.x.x.js

Loading...
View Options

keyserver/flow-typed/npm/frog_v0.18.x.js

Loading...
View Options

keyserver/flow-typed/npm/hono_vx.x.x.js

Loading...
View Options

keyserver/images/default_farcaster_channel_cover.png

Loading...
View Options

keyserver/src/frog/frog.js

Loading...