[keyserver] Add Thread Invitation box to the frame
AcceptedPublic
Actions

Authored by will on Thu, Nov 21, 11:32 PM.

Details

Reviewers

ashoat
varun

Summary

This adds the thread invitation box to the frame image

Depends on D13985

Test Plan

Tested on the warpcast frame validator and confirmed that the thread invitation box appeared properly

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Thu, Nov 21, 11:32 PM

Herald added a subscriber: tomek. · View Herald TranscriptThu, Nov 21, 11:32 PM

will edited the test plan for this revision. (Show Details)Thu, Nov 21, 11:33 PM

will edited the test plan for this revision. (Show Details)

will added a child revision: D13999: [keyserver] use default channel cover image stored on in keyserver/images in frame.Thu, Nov 21, 11:37 PM

Harbormaster completed remote builds in B32759: Diff 45935.Thu, Nov 21, 11:49 PM

will requested review of this revision.Thu, Nov 21, 11:49 PM

Can you move the conditional outside the JSX before landing? Let me know if this feedback is confusing

keyserver/src/frog/frog.js
99–110	We generally avoid this sort of conditional in our codebase

This revision is now accepted and ready to land.Sat, Nov 23, 6:27 AM

ashoat added inline comments.Sat, Nov 23, 6:33 AM

keyserver/src/frog/frog.js
48–51	What username is being displayed here, Farcaster or Comm? If it's a Farcaster username, why do we need to do this? I thought you indicated the usernames were at most 16 characters?

Revision Contents
Changeset List

Path

Size

keyserver/

src/

frog/

frog.js

72 lines

Diff 45935

View Options

keyserver/src/frog/frog.js

[keyserver] Add Thread Invitation box to the frameAcceptedPublicActions