[keyserver] remove duplicate content-type application/json header in call to assignBlobHolder
ClosedPublic
Actions

Authored by will on Dec 6 2024, 5:46 PM.

Details

Reviewers

varun
bartek
ashoat

Commits

rCOMMb1a937ba765c: [keyserver] remove duplicate content-type application/json header in call to…

Summary

Remove duplicate content type header in assign blob holder request to blob service.

In testing my farcaster bot, calls to createOrUpdatePublicLink were failing as it would eventually call assignBlobHolder with two duplicate content-type headers, resulting in a 400 Bad Request from the blob service.

We can fix this by specifying createRequestHeaders's includeContentType parameter as false

Linear Issue: https://linear.app/comm/issue/ENG-9986/running-into-an-issue-of-createorupdatepubliclink-failing-to-upload-a

Test Plan

In applying this change, the farcaster bot properly was able to upload invite link blobs without errors

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Dec 6 2024, 5:46 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 6 2024, 5:46 PM

will retitled this revision from [keyserver] remove duplicate content-type application/json header in call to assign blob holder to [keyserver] remove duplicate content-type application/json header in call to assignBlobHolder.Dec 6 2024, 5:56 PM

will retitled this revision from [keyserver] remove duplicate content-type application/json header in call to assignBlobHolder to [keyserver] remove duplicate content-type application/json header in assignBlobHolder.

will retitled this revision from [keyserver] remove duplicate content-type application/json header in assignBlobHolder to [keyserver] remove duplicate content-type application/json header in call to assignBlobHolder.

Harbormaster completed remote builds in B32953: Diff 46247.Dec 6 2024, 6:05 PM

will requested review of this revision.Dec 6 2024, 6:05 PM

will added a child revision: D13926: [keyserver] add frog, hono, @hono/node-server as keyserver dependencies.Dec 6 2024, 6:40 PM

will edited the summary of this revision. (Show Details)Dec 6 2024, 6:47 PM

ashoat accepted this revision.Dec 6 2024, 6:53 PM

This revision is now accepted and ready to land.Dec 6 2024, 6:53 PM

Closed by commit rCOMMb1a937ba765c: [keyserver] remove duplicate content-type application/json header in call to… (authored by will). · Explain WhyDec 6 2024, 8:47 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMb1a937ba765c: [keyserver] remove duplicate content-type application/json header in call to….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

services/

blob.js

2 lines

Diff 46255

View Options

keyserver/src/services/blob.js

Show All 21 Lines
import { SafeAreaView } from 'react-native-safe-area-context';		import { SafeAreaView } from 'react-native-safe-area-context';

import { useIsLoggedInToAuthoritativeKeyserver } from 'lib/hooks/account-hooks.js';		import { useIsLoggedInToAuthoritativeKeyserver } from 'lib/hooks/account-hooks.js';
import { setActiveSessionRecoveryActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';		import { setActiveSessionRecoveryActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { usePersistedStateLoaded } from 'lib/selectors/app-state-selectors.js';		import { usePersistedStateLoaded } from 'lib/selectors/app-state-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js';		import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { recoveryFromReduxActionSources } from 'lib/types/account-types.js';		import { recoveryFromReduxActionSources } from 'lib/types/account-types.js';
import { useDispatch } from 'lib/utils/redux-utils.js';		import { useDispatch } from 'lib/utils/redux-utils.js';
import { usingCommServicesAccessToken } from 'lib/utils/services-utils.js';		import {
		usingCommServicesAccessToken,
		usingRestoreFlow,
		} from 'lib/utils/services-utils.js';

import { splashBackgroundURI } from './background-info.js';		import { splashBackgroundURI } from './background-info.js';
import FullscreenSIWEPanel from './fullscreen-siwe-panel.react.js';		import FullscreenSIWEPanel from './fullscreen-siwe-panel.react.js';
import LogInPanel from './log-in-panel.react.js';		import LogInPanel from './log-in-panel.react.js';
import type { LogInState } from './log-in-panel.react.js';		import type { LogInState } from './log-in-panel.react.js';
import LoggedOutStaffInfo from './logged-out-staff-info.react.js';		import LoggedOutStaffInfo from './logged-out-staff-info.react.js';
import { authoritativeKeyserverID } from '../authoritative-keyserver.js';		import { authoritativeKeyserverID } from '../authoritative-keyserver.js';
import KeyboardAvoidingView from '../components/keyboard-avoiding-view.react.js';		import KeyboardAvoidingView from '../components/keyboard-avoiding-view.react.js';
▲ Show 20 Lines • Show All 452 Lines • ▼ Show 20 Lines	const buttonsViewStyle = React.useMemo(
[styles.buttonContainer, buttonsViewOpacity],		[styles.buttonContainer, buttonsViewOpacity],
);		);
const buttons = React.useMemo(() => {		const buttons = React.useMemo(() => {
if (mode.curMode !== 'prompt') {		if (mode.curMode !== 'prompt') {
return null;		return null;
}		}

const signInButtons = [];		const signInButtons = [];
		if (!usingRestoreFlow) {
signInButtons.push(		signInButtons.push(
<TouchableOpacity		<TouchableOpacity
onPress={onPressLogIn}		onPress={onPressLogIn}
style={classicAuthButtonStyle}		style={classicAuthButtonStyle}
activeOpacity={0.6}		activeOpacity={0.6}
key="login-form"		key="login-form"
>		>
<Text style={classicAuthButtonTextStyle}>Sign in</Text>		<Text style={classicAuthButtonTextStyle}>Sign in</Text>
</TouchableOpacity>,		</TouchableOpacity>,
);		);
if (__DEV__) {		}
		if (__DEV__ \|\| usingRestoreFlow) {
		const buttonText = usingRestoreFlow ? 'Sign in' : 'Sign in (QR)';
signInButtons.push(		signInButtons.push(
<TouchableOpacity		<TouchableOpacity
onPress={onPressQRCodeSignIn}		onPress={onPressQRCodeSignIn}
style={classicAuthButtonStyle}		style={classicAuthButtonStyle}
activeOpacity={0.6}		activeOpacity={0.6}
key="qr-code-login"		key="qr-code-login"
>		>
<Text style={classicAuthButtonTextStyle}>Sign in (QR)</Text>		<Text style={classicAuthButtonTextStyle}>{buttonText}</Text>
</TouchableOpacity>,		</TouchableOpacity>,
);		);
}		}

return (		let siweSection = null;
<AnimatedView style={buttonsViewStyle}>		if (!usingRestoreFlow) {
<LoggedOutStaffInfo />		siweSection = (
		<>
<TouchableOpacity		<TouchableOpacity
onPress={onPressSIWE}		onPress={onPressSIWE}
style={siweAuthButtonStyle}		style={siweAuthButtonStyle}
activeOpacity={0.6}		activeOpacity={0.6}
>		>
<View style={styles.siweIcon}>		<View style={styles.siweIcon}>
<EthereumLogo />		<EthereumLogo />
</View>		</View>
<Text style={siweAuthButtonTextStyle}>Sign in with Ethereum</Text>		<Text style={siweAuthButtonTextStyle}>Sign in with Ethereum</Text>
</TouchableOpacity>		</TouchableOpacity>
<View style={styles.siweOr}>		<View style={styles.siweOr}>
<View style={styles.siweOrLeftHR} />		<View style={styles.siweOrLeftHR} />
<Text style={styles.siweOrText}>or</Text>		<Text style={styles.siweOrText}>or</Text>
<View style={styles.siweOrRightHR} />		<View style={styles.siweOrRightHR} />
</View>		</View>
		</>
		);
		}

		return (
		<AnimatedView style={buttonsViewStyle}>
		<LoggedOutStaffInfo />
		{siweSection}
<View style={styles.signInButtons}>{signInButtons}</View>		<View style={styles.signInButtons}>{signInButtons}</View>
<View style={styles.registerButtons}>		<View style={styles.registerButtons}>
<TouchableOpacity		<TouchableOpacity
onPress={onPressNewRegister}		onPress={onPressNewRegister}
style={classicAuthButtonStyle}		style={classicAuthButtonStyle}
activeOpacity={0.6}		activeOpacity={0.6}
key="new"		key="new"
>		>
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines

[keyserver] remove duplicate content-type application/json header in call to assignBlobHolderClosedPublicActions