Page MenuHomePhabricator
Differential D14086

[keyserver] setup reverse proxy from keyserver router to frog hono server
ClosedPublic
Actions

Authored by will on Dec 5 2024, 11:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 15 2025, 1:40 AM
Unknown Object (File)
Mar 15 2025, 1:40 AM
Unknown Object (File)
Mar 15 2025, 1:40 AM
Unknown Object (File)
Mar 15 2025, 1:40 AM
Unknown Object (File)
Mar 15 2025, 1:40 AM
Unknown Object (File)
Mar 15 2025, 1:40 AM
Unknown Object (File)
Mar 11 2025, 4:10 PM
Unknown Object (File)
Mar 11 2025, 4:10 PM
View All 66 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMM56ad401d2bc1: [keyserver] setup reverse proxy from keyserver router to frog hono server
Summary

This implements the reverse proxy on the express server to point to the frog
hono server.

Depends on D13999

Test Plan

Verified by using ngrok to localhost 3000 and accessing the frog hono server.
Also confirmed was able to access frog hono server on my self-hosted keyserver

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Dec 5 2024, 11:29 PM
Herald added a subscriber: tomek. · View Herald TranscriptDec 5 2024, 11:29 PM
Harbormaster completed remote builds in B32940: Diff 46224.Dec 5 2024, 11:47 PM
will requested review of this revision.Dec 5 2024, 11:47 PM
will added a child revision: D14092: [lib] include embeds in neynar client's postCast method.Dec 6 2024, 8:26 PM
will added a child revision: D14093: [keyserver] replace farcaster bot reply text with frame.Dec 6 2024, 8:34 PM
will removed a child revision: D14093: [keyserver] replace farcaster bot reply text with frame.Dec 7 2024, 8:50 AM
ashoat accepted this revision.Dec 7 2024, 12:45 PM
ashoat added inline comments.
keyserver/src/frog/frog.js
32 ↗(On Diff #46224)

What's this title field for?

This revision is now accepted and ready to land.Dec 7 2024, 12:45 PM
will added inline comments.Dec 9 2024, 1:01 PM
keyserver/src/frog/frog.js
32 ↗(On Diff #46224)

title is a required parameter to the Frog constructor.

In a frame response, we end up setting the og:title tag as whatever we specify as title. I haven't actually seen this utilized when we render the frame on the validator or warpcast, so I don't believe the title matters too much

I'm actually going to replace the title with Comm Frame. The example frog docs has the following line:
"export const app = new Frog({ title: 'Frog Frame' })"
so I think we can think of it as the name of our frame

will updated this revision to Diff 46264.Dec 9 2024, 1:03 PM

rebase

will added inline comments.Dec 9 2024, 1:07 PM
keyserver/src/frog/frog.js
32 ↗(On Diff #46224)

Changed title to "Comm Frame" in hello world diff: https://phab.comm.dev/D13947

ashoat added a comment.Dec 9 2024, 1:21 PM

I haven't actually seen this utilized when we render the frame on the validator or warpcast, so I don't believe the title matters too much

Sounds like you don't know how it's used. It would be good to figure out before landing this... I worry that, for instance, we'll end up with an application titled "Comm Frame" in some mini-app directory.

I think it would probably be better to just use "Comm" if you truly have no clue what this is or how it is used, even after spending an hour or so trying to dig up information.

will added a comment.Dec 9 2024, 1:24 PM
In D14086#392872, @ashoat wrote:

I haven't actually seen this utilized when we render the frame on the validator or warpcast, so I don't believe the title matters too much

Sounds like you don't know how it's used. It would be good to figure out before landing this... I worry that, for instance, we'll end up with an application titled "Comm Frame" in some mini-app directory.

I think it would probably be better to just use "Comm" if you truly have no clue what this is or how it is used, even after spending an hour or so trying to dig up information.

Got it. Given that I already tried digging up information on how it's used and wasn't able to come up with much, I'll just rebase with the title as "Comm"

Harbormaster completed remote builds in B32968: Diff 46264.Dec 9 2024, 1:24 PM
will updated this revision to Diff 46268.Dec 9 2024, 1:52 PM

rebase

Harbormaster completed remote builds in B32972: Diff 46268.Dec 9 2024, 2:24 PM
Closed by commit rCOMM56ad401d2bc1: [keyserver] setup reverse proxy from keyserver router to frog hono server (authored by will). · Explain WhyDec 9 2024, 4:56 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM56ad401d2bc1: [keyserver] setup reverse proxy from keyserver router to frog hono server.

Revision Contents
Changeset List

PathSize
keyserver/
flow-typed/
npm/
9 lines
src/
frog/
33 lines
26 lines

Diff 46281

View Options

keyserver/flow-typed/npm/hono_vx.x.x.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { useAddUsersPermissions } from 'lib/permissions/add-users-permissions.js';
import { useUserSearchIndex } from 'lib/selectors/nav-selectors.js'; import { useUserSearchIndex } from 'lib/selectors/nav-selectors.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors.js'; import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import { import { roleIsAdminRole } from 'lib/shared/thread-utils.js';
roleIsAdminRole,
useThreadHasPermission,
} from 'lib/shared/thread-utils.js';
import type { RelativeMemberInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { RelativeMemberInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { threadTypeIsCommunityRoot } from 'lib/types/thread-types-enum.js';
import { useRolesFromCommunityThreadInfo } from 'lib/utils/role-utils.js'; import { useRolesFromCommunityThreadInfo } from 'lib/utils/role-utils.js';
import { AddMembersModal } from './add-members-modal.react.js'; import { AddMembersModal } from './add-members-modal.react.js';
import ThreadMembersList from './members-list.react.js'; import ThreadMembersList from './members-list.react.js';
import css from './members-modal.css'; import css from './members-modal.css';
import Button from '../../../components/button.react.js'; import Button from '../../../components/button.react.js';
import Tabs, { type TabData } from '../../../components/tabs.react.js'; import Tabs, { type TabData } from '../../../components/tabs.react.js';
import ManageInviteLinksModal from '../../../invite-links/manage-invite-links-modal.react.js'; import ManageInviteLinksModal from '../../../invite-links/manage-invite-links-modal.react.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines const renderModalContent = React.useCallback(
), ),
[threadID], [threadID],
); );
const { pushModal, popModal } = useModalContext(); const { pushModal, popModal } = useModalContext();
const threadInfo = useSelector(state => threadInfoSelector(state)[threadID]); const threadInfo = useSelector(state => threadInfoSelector(state)[threadID]);
const inviteLink = useSelector(primaryInviteLinksSelector)[threadID]; const { inviteLink, canManageLinks, canAddMembers, isCommunityRoot } =
const canManageLinks = useThreadHasPermission( useAddUsersPermissions(threadInfo);
threadInfo,
threadPermissions.MANAGE_INVITE_LINKS,
);
const isCommunityRoot = threadTypeIsCommunityRoot(threadInfo.type);
const onClickAddMembers = React.useCallback(() => { const onClickAddMembers = React.useCallback(() => {
if (!isCommunityRoot) { if (!isCommunityRoot) {
pushModal(<AddMembersModal onClose={popModal} threadID={threadID} />); pushModal(<AddMembersModal onClose={popModal} threadID={threadID} />);
} else if (inviteLink) { } else if (inviteLink) {
pushModal(<ViewInviteLinkModal inviteLink={inviteLink} />); pushModal(<ViewInviteLinkModal inviteLink={inviteLink} />);
} else if (canManageLinks) { } else if (canManageLinks) {
pushModal(<ManageInviteLinksModal communityID={threadID} />); pushModal(<ManageInviteLinksModal communityID={threadID} />);
} }
}, [ }, [
canManageLinks, canManageLinks,
inviteLink, inviteLink,
isCommunityRoot, isCommunityRoot,
popModal, popModal,
pushModal, pushModal,
threadID, threadID,
]); ]);
const canAddMembersViaInviteLink =
isCommunityRoot && (inviteLink || canManageLinks);
const hasAddMembersPermission = useThreadHasPermission(
threadInfo,
threadPermissions.ADD_MEMBERS,
);
const canAddMembersManually = hasAddMembersPermission && !isCommunityRoot;
const canAddMembers = canAddMembersManually || canAddMembersViaInviteLink;
const addMembersButton = React.useMemo(() => { const addMembersButton = React.useMemo(() => {
if (!canAddMembers) { if (!canAddMembers) {
return null; return null;
} }
return ( return (
<div className={css.addNewMembers}> <div className={css.addNewMembers}>
<Button variant="filled" onClick={onClickAddMembers}> <Button variant="filled" onClick={onClickAddMembers}>
Add members Add members
Show All 19 Lines
View Options

keyserver/src/frog/frog.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { useAddUsersPermissions } from 'lib/permissions/add-users-permissions.js';
import { useUserSearchIndex } from 'lib/selectors/nav-selectors.js'; import { useUserSearchIndex } from 'lib/selectors/nav-selectors.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors.js'; import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import { import { roleIsAdminRole } from 'lib/shared/thread-utils.js';
roleIsAdminRole,
useThreadHasPermission,
} from 'lib/shared/thread-utils.js';
import type { RelativeMemberInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { RelativeMemberInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { threadTypeIsCommunityRoot } from 'lib/types/thread-types-enum.js';
import { useRolesFromCommunityThreadInfo } from 'lib/utils/role-utils.js'; import { useRolesFromCommunityThreadInfo } from 'lib/utils/role-utils.js';
import { AddMembersModal } from './add-members-modal.react.js'; import { AddMembersModal } from './add-members-modal.react.js';
import ThreadMembersList from './members-list.react.js'; import ThreadMembersList from './members-list.react.js';
import css from './members-modal.css'; import css from './members-modal.css';
import Button from '../../../components/button.react.js'; import Button from '../../../components/button.react.js';
import Tabs, { type TabData } from '../../../components/tabs.react.js'; import Tabs, { type TabData } from '../../../components/tabs.react.js';
import ManageInviteLinksModal from '../../../invite-links/manage-invite-links-modal.react.js'; import ManageInviteLinksModal from '../../../invite-links/manage-invite-links-modal.react.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines const renderModalContent = React.useCallback(
), ),
[threadID], [threadID],
); );
const { pushModal, popModal } = useModalContext(); const { pushModal, popModal } = useModalContext();
const threadInfo = useSelector(state => threadInfoSelector(state)[threadID]); const threadInfo = useSelector(state => threadInfoSelector(state)[threadID]);
const inviteLink = useSelector(primaryInviteLinksSelector)[threadID]; const { inviteLink, canManageLinks, canAddMembers, isCommunityRoot } =
const canManageLinks = useThreadHasPermission( useAddUsersPermissions(threadInfo);
threadInfo,
threadPermissions.MANAGE_INVITE_LINKS,
);
const isCommunityRoot = threadTypeIsCommunityRoot(threadInfo.type);
const onClickAddMembers = React.useCallback(() => { const onClickAddMembers = React.useCallback(() => {
if (!isCommunityRoot) { if (!isCommunityRoot) {
pushModal(<AddMembersModal onClose={popModal} threadID={threadID} />); pushModal(<AddMembersModal onClose={popModal} threadID={threadID} />);
} else if (inviteLink) { } else if (inviteLink) {
pushModal(<ViewInviteLinkModal inviteLink={inviteLink} />); pushModal(<ViewInviteLinkModal inviteLink={inviteLink} />);
} else if (canManageLinks) { } else if (canManageLinks) {
pushModal(<ManageInviteLinksModal communityID={threadID} />); pushModal(<ManageInviteLinksModal communityID={threadID} />);
} }
}, [ }, [
canManageLinks, canManageLinks,
inviteLink, inviteLink,
isCommunityRoot, isCommunityRoot,
popModal, popModal,
pushModal, pushModal,
threadID, threadID,
]); ]);
const canAddMembersViaInviteLink =
isCommunityRoot && (inviteLink || canManageLinks);
const hasAddMembersPermission = useThreadHasPermission(
threadInfo,
threadPermissions.ADD_MEMBERS,
);
const canAddMembersManually = hasAddMembersPermission && !isCommunityRoot;
const canAddMembers = canAddMembersManually || canAddMembersViaInviteLink;
const addMembersButton = React.useMemo(() => { const addMembersButton = React.useMemo(() => {
if (!canAddMembers) { if (!canAddMembers) {
return null; return null;
} }
return ( return (
<div className={css.addNewMembers}> <div className={css.addNewMembers}>
<Button variant="filled" onClick={onClickAddMembers}> <Button variant="filled" onClick={onClickAddMembers}>
Add members Add members
Show All 19 Lines
View Options

keyserver/src/keyserver.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { useAddUsersPermissions } from 'lib/permissions/add-users-permissions.js';
import { useUserSearchIndex } from 'lib/selectors/nav-selectors.js'; import { useUserSearchIndex } from 'lib/selectors/nav-selectors.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors.js'; import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import { import { roleIsAdminRole } from 'lib/shared/thread-utils.js';
roleIsAdminRole,
useThreadHasPermission,
} from 'lib/shared/thread-utils.js';
import type { RelativeMemberInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { RelativeMemberInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { threadTypeIsCommunityRoot } from 'lib/types/thread-types-enum.js';
import { useRolesFromCommunityThreadInfo } from 'lib/utils/role-utils.js'; import { useRolesFromCommunityThreadInfo } from 'lib/utils/role-utils.js';
import { AddMembersModal } from './add-members-modal.react.js'; import { AddMembersModal } from './add-members-modal.react.js';
import ThreadMembersList from './members-list.react.js'; import ThreadMembersList from './members-list.react.js';
import css from './members-modal.css'; import css from './members-modal.css';
import Button from '../../../components/button.react.js'; import Button from '../../../components/button.react.js';
import Tabs, { type TabData } from '../../../components/tabs.react.js'; import Tabs, { type TabData } from '../../../components/tabs.react.js';
import ManageInviteLinksModal from '../../../invite-links/manage-invite-links-modal.react.js'; import ManageInviteLinksModal from '../../../invite-links/manage-invite-links-modal.react.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines const renderModalContent = React.useCallback(
), ),
[threadID], [threadID],
); );
const { pushModal, popModal } = useModalContext(); const { pushModal, popModal } = useModalContext();
const threadInfo = useSelector(state => threadInfoSelector(state)[threadID]); const threadInfo = useSelector(state => threadInfoSelector(state)[threadID]);
const inviteLink = useSelector(primaryInviteLinksSelector)[threadID]; const { inviteLink, canManageLinks, canAddMembers, isCommunityRoot } =
const canManageLinks = useThreadHasPermission( useAddUsersPermissions(threadInfo);
threadInfo,
threadPermissions.MANAGE_INVITE_LINKS,
);
const isCommunityRoot = threadTypeIsCommunityRoot(threadInfo.type);
const onClickAddMembers = React.useCallback(() => { const onClickAddMembers = React.useCallback(() => {
if (!isCommunityRoot) { if (!isCommunityRoot) {
pushModal(<AddMembersModal onClose={popModal} threadID={threadID} />); pushModal(<AddMembersModal onClose={popModal} threadID={threadID} />);
} else if (inviteLink) { } else if (inviteLink) {
pushModal(<ViewInviteLinkModal inviteLink={inviteLink} />); pushModal(<ViewInviteLinkModal inviteLink={inviteLink} />);
} else if (canManageLinks) { } else if (canManageLinks) {
pushModal(<ManageInviteLinksModal communityID={threadID} />); pushModal(<ManageInviteLinksModal communityID={threadID} />);
} }
}, [ }, [
canManageLinks, canManageLinks,
inviteLink, inviteLink,
isCommunityRoot, isCommunityRoot,
popModal, popModal,
pushModal, pushModal,
threadID, threadID,
]); ]);
const canAddMembersViaInviteLink =
isCommunityRoot && (inviteLink || canManageLinks);
const hasAddMembersPermission = useThreadHasPermission(
threadInfo,
threadPermissions.ADD_MEMBERS,
);
const canAddMembersManually = hasAddMembersPermission && !isCommunityRoot;
const canAddMembers = canAddMembersManually || canAddMembersViaInviteLink;
const addMembersButton = React.useMemo(() => { const addMembersButton = React.useMemo(() => {
if (!canAddMembers) { if (!canAddMembers) {
return null; return null;
} }
return ( return (
<div className={css.addNewMembers}> <div className={css.addNewMembers}>
<Button variant="filled" onClick={onClickAddMembers}> <Button variant="filled" onClick={onClickAddMembers}>
Add members Add members
Show All 19 Lines