[keyserver] setup reverse proxy from keyserver router to frog hono server
ClosedPublic
Actions

Authored by will on Thu, Dec 5, 11:29 PM.

Details

Reviewers

ashoat
varun

Commits

rCOMM56ad401d2bc1: [keyserver] setup reverse proxy from keyserver router to frog hono server

Summary

This implements the reverse proxy on the express server to point to the frog
hono server.

Depends on D13999

Test Plan

Verified by using ngrok to localhost 3000 and accessing the frog hono server.
Also confirmed was able to access frog hono server on my self-hosted keyserver

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Thu, Dec 5, 11:29 PM

Herald added a subscriber: tomek. · View Herald TranscriptThu, Dec 5, 11:29 PM

Harbormaster completed remote builds in B32940: Diff 46224.Thu, Dec 5, 11:47 PM

will requested review of this revision.Thu, Dec 5, 11:47 PM

will added a child revision: D14092: [lib] include embeds in neynar client's postCast method.Fri, Dec 6, 8:26 PM

will added a child revision: D14093: [keyserver] replace farcaster bot reply text with frame.Fri, Dec 6, 8:34 PM

will removed a child revision: D14093: [keyserver] replace farcaster bot reply text with frame.Sat, Dec 7, 8:50 AM

ashoat accepted this revision.Sat, Dec 7, 12:45 PM

ashoat added inline comments.

keyserver/src/frog/frog.js
32 ↗	(On Diff #46224)	What's this `title` field for?

This revision is now accepted and ready to land.Sat, Dec 7, 12:45 PM

will added inline comments.Mon, Dec 9, 1:01 PM

keyserver/src/frog/frog.js
32 ↗	(On Diff #46224)	`title` is a required parameter to the `Frog` constructor. In a frame response, we end up setting the `og:title` tag as whatever we specify as `title`. I haven't actually seen this utilized when we render the frame on the validator or warpcast, so I don't believe the title matters too much I'm actually going to replace the title with `Comm Frame`. The example frog docs has the following line: `"export const app = new Frog({ title: 'Frog Frame' })"` so I think we can think of it as the name of our frame

rebase

will added inline comments.Mon, Dec 9, 1:07 PM

keyserver/src/frog/frog.js
32 ↗	(On Diff #46224)	Changed title to "Comm Frame" in hello world diff: https://phab.comm.dev/D13947

I haven't actually seen this utilized when we render the frame on the validator or warpcast, so I don't believe the title matters too much

Sounds like you don't know how it's used. It would be good to figure out before landing this... I worry that, for instance, we'll end up with an application titled "Comm Frame" in some mini-app directory.

I think it would probably be better to just use "Comm" if you truly have no clue what this is or how it is used, even after spending an hour or so trying to dig up information.

In D14086#392872, @ashoat wrote:

I haven't actually seen this utilized when we render the frame on the validator or warpcast, so I don't believe the title matters too much

Sounds like you don't know how it's used. It would be good to figure out before landing this... I worry that, for instance, we'll end up with an application titled "Comm Frame" in some mini-app directory.

I think it would probably be better to just use "Comm" if you truly have no clue what this is or how it is used, even after spending an hour or so trying to dig up information.

Got it. Given that I already tried digging up information on how it's used and wasn't able to come up with much, I'll just rebase with the title as "Comm"

Harbormaster completed remote builds in B32968: Diff 46264.Mon, Dec 9, 1:24 PM

rebase

Harbormaster completed remote builds in B32972: Diff 46268.Mon, Dec 9, 2:24 PM

Closed by commit rCOMM56ad401d2bc1: [keyserver] setup reverse proxy from keyserver router to frog hono server (authored by will). · Explain WhyMon, Dec 9, 4:56 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM56ad401d2bc1: [keyserver] setup reverse proxy from keyserver router to frog hono server.