[keyserver] Add Thread Invitation box to the frame
ClosedPublic
Actions

Authored by will on Nov 21 2024, 11:32 PM.

Details

Reviewers

ashoat
varun

Commits

rCOMMc74348d9a0c0: [keyserver] Add Thread Invitation box to the frame

Summary

This adds the thread invitation box to the frame image

Depends on D13985

Test Plan

Tested on the warpcast frame validator and confirmed that the thread invitation box appeared properly

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Nov 21 2024, 11:32 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 21 2024, 11:32 PM

will edited the test plan for this revision. (Show Details)Nov 21 2024, 11:33 PM

will edited the test plan for this revision. (Show Details)

will added a child revision: D13999: [keyserver] use default channel cover image stored on in keyserver/images in frame.Nov 21 2024, 11:37 PM

Harbormaster completed remote builds in B32759: Diff 45935.Nov 21 2024, 11:49 PM

will requested review of this revision.Nov 21 2024, 11:49 PM

Can you move the conditional outside the JSX before landing? Let me know if this feedback is confusing

keyserver/src/frog/frog.js
99–110	We generally avoid this sort of conditional in our codebase

This revision is now accepted and ready to land.Nov 23 2024, 6:27 AM

ashoat added inline comments.Nov 23 2024, 6:33 AM

keyserver/src/frog/frog.js
48–51	What username is being displayed here, Farcaster or Comm? If it's a Farcaster username, why do we need to do this? I thought you indicated the usernames were at most 16 characters?

will added inline comments.Dec 6 2024, 7:24 PM

keyserver/src/frog/frog.js
48–51	In the linear comment below I specify that there's the possibility of people creating their own Comm frame url with an unusually long username as a parameter. Unlikely but I included this just in case to prevent anyone from being able to render a frame with a username that goes out of the Thread Invitation box

feedback

Harbormaster completed remote builds in B32957: Diff 46251.Dec 6 2024, 7:45 PM

Closed by commit rCOMMc74348d9a0c0: [keyserver] Add Thread Invitation box to the frame (authored by will). · Explain WhyDec 9 2024, 4:56 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMc74348d9a0c0: [keyserver] Add Thread Invitation box to the frame.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

frog/

frog.js

72 lines

Diff 45935

View Options

keyserver/src/frog/frog.js

Show First 20 Lines • Show All 573 Lines • ▼ Show 20 Lines	async keyserverAuthInfo => {

const responses: { +[string]: ClientLogInResponse } =		const responses: { +[string]: ClientLogInResponse } =
await callKeyserverEndpoint(		await callKeyserverEndpoint(
'keyserver_auth',		'keyserver_auth',
requests,		requests,
keyserverAuthCallSingleKeyserverEndpointOptions,		keyserverAuthCallSingleKeyserverEndpointOptions,
);		);

const userInfosArrays = [];

let threadInfos: RawThreadInfos = {};		let threadInfos: RawThreadInfos = {};
const calendarResult: WritableCalendarResult = {		const calendarResult: WritableCalendarResult = {
calendarQuery: keyserverAuthInfo.calendarQuery,		calendarQuery: keyserverAuthInfo.calendarQuery,
rawEntryInfos: [],		rawEntryInfos: [],
};		};
const messagesResult: WritableGenericMessagesResult = {		const messagesResult: WritableGenericMessagesResult = {
messageInfos: [],		messageInfos: [],
truncationStatus: {},		truncationStatus: {},
Show All 21 Lines	for (const keyserverID in responses) {
messagesResult.currentAsOf = {		messagesResult.currentAsOf = {
...messagesResult.currentAsOf,		...messagesResult.currentAsOf,
[keyserverID]: responses[keyserverID].serverTime,		[keyserverID]: responses[keyserverID].serverTime,
};		};
updatesCurrentAsOf = {		updatesCurrentAsOf = {
...updatesCurrentAsOf,		...updatesCurrentAsOf,
[keyserverID]: responses[keyserverID].serverTime,		[keyserverID]: responses[keyserverID].serverTime,
};		};
userInfosArrays.push(responses[keyserverID].userInfos);
userInfosArrays.push(responses[keyserverID].cookieChange.userInfos);
}		}

		const userInfosArrays = [
		responses[authoritativeKeyserverID()].userInfos,
		responses[authoritativeKeyserverID()].cookieChange.userInfos,
		tomekUnsubmitted Not Done Inline Actions I don't think it is guaranteed that there will always be a response from the authoritative keyserver, e.g. when adding a new keyserver. We probably should add a condition here and extend a test plan to verify a non-auth keyserver auth. tomek: I don't think it is guaranteed that there will always be a response from the authoritative…
		];

const userInfos = mergeUserInfos(...userInfosArrays);		const userInfos = mergeUserInfos(...userInfosArrays);

return {		return {
threadInfos,		threadInfos,
currentUserInfo: responses[authoritativeKeyserverID()]?.currentUserInfo,		currentUserInfo: responses[authoritativeKeyserverID()]?.currentUserInfo,
calendarResult,		calendarResult,
messagesResult,		messagesResult,
userInfos,		userInfos,
▲ Show 20 Lines • Show All 526 Lines • Show Last 20 Lines

[keyserver] Add Thread Invitation box to the frameClosedPublicActions