Page MenuHomePhabricator

[keyserver] Add Thread Invitation box to the frame
ClosedPublic

Authored by will on Nov 21 2024, 11:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 2:32 AM
Unknown Object (File)
Wed, Dec 18, 8:44 AM
Unknown Object (File)
Tue, Dec 17, 4:25 AM
Unknown Object (File)
Mon, Dec 16, 5:29 AM
Unknown Object (File)
Sun, Dec 15, 1:01 PM
Unknown Object (File)
Sat, Dec 14, 11:49 AM
Unknown Object (File)
Fri, Dec 6, 12:53 AM
Unknown Object (File)
Thu, Dec 5, 5:44 PM
Subscribers

Details

Summary

This adds the thread invitation box to the frame image

Depends on D13985

Test Plan

Tested on the warpcast frame validator and confirmed that the thread invitation box appeared properly

image.png (926×1 px, 584 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will edited the test plan for this revision. (Show Details)
will requested review of this revision.Nov 21 2024, 11:49 PM

Can you move the conditional outside the JSX before landing? Let me know if this feedback is confusing

keyserver/src/frog/frog.js
99–110 ↗(On Diff #45935)

We generally avoid this sort of conditional in our codebase

This revision is now accepted and ready to land.Sat, Nov 23, 6:27 AM
keyserver/src/frog/frog.js
48–51 ↗(On Diff #45935)

What username is being displayed here, Farcaster or Comm?

If it's a Farcaster username, why do we need to do this? I thought you indicated the usernames were at most 16 characters?

keyserver/src/frog/frog.js
48–51 ↗(On Diff #45935)

In the linear comment below I specify that there's the possibility of people creating their own Comm frame url with an unusually long username as a parameter.

Unlikely but I included this just in case to prevent anyone from being able to render a frame with a username that goes out of the Thread Invitation box