[keyserver] use default channel cover image stored on in keyserver/images in frame
ClosedPublic
Actions

Authored by will on Nov 22 2024, 7:37 AM.

Details

Reviewers

ashoat
varun

Commits

rCOMM406616992f71: [keyserver] use default channel cover image stored on in keyserver/images in…

Summary

Instead of using the link to the warpcast's default channel cover image, we store it on the keyserver and serve it at a frog hono route to be used by the frame's `<img /> JSX element as the src

Depends on D13998

Test Plan

Verified on the warpcast frame validator and confirmed that specifying a channel with no custom channel cover still resolved to the same default cover image

Diff Detail

Repository

rCOMM Comm

Branch

wyilio/frames

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Nov 22 2024, 7:37 AM

Herald added a subscriber: tomek. · View Herald TranscriptNov 22 2024, 7:37 AM

will edited the test plan for this revision. (Show Details)Nov 22 2024, 7:37 AM

will edited the test plan for this revision. (Show Details)

will edited the summary of this revision. (Show Details)

will edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B32760: Diff 45936.Nov 22 2024, 7:53 AM

will requested review of this revision.Nov 22 2024, 7:53 AM

ashoat accepted this revision.Nov 23 2024, 2:35 PM

ashoat added inline comments.

keyserver/flow-typed/npm/hono_vx.x.x.js
11	Weird that you're naming one parameter but not the other
12	Are you sure it returns `void`? If you're just saying that because our usage doesn't care about the return value, then we should say `mixed`. But if you're sure it's `void` (eg. from TS types) that's fine