Details

Reviewers

varun
will

Commits

rCOMM617ed804e81d: [lib] Fix incorrect timestamps for sidebars
rCOMM02cb5b4bee19: [lib] Fix incorrect timestamps for sidebars

Summary

This addresses ENG-9951:

Fixes useSidebarInfos's initial ordering to sort on lastUpdatedAtLeastTime (a number) instead of lastUpdatedTime (a promise). Flow failed to catch this because Lodash's usage is hard to type.
Fixes lastUpdatedTimeIncludingSidebars to consider all sidebars, instead of trusting the first one in the initial order to have the most recent timestamp.
Fixes getAllFinalSidebarItems to reorder after all promises resolve.

Test Plan

Tested on both native (my iOS device running a Release build pointed at prod) and web (my comm.software staging environment that uses prod data)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 20 2024, 9:04 AM

Herald added a subscriber: tomek. · View Herald TranscriptNov 20 2024, 9:04 AM

ashoat published this revision for review.Nov 20 2024, 9:08 AM

Harbormaster completed remote builds in B32739: Diff 45913.Nov 20 2024, 9:28 AM

will accepted this revision.Nov 20 2024, 3:36 PM

This revision is now accepted and ready to land.Nov 20 2024, 3:36 PM

Changes in initial version broke useSearchSidebars comparison algo. Moved the sorting to getSidebarItems instead, which isn't used in useSearchSidebars and is only used in chat-selectors.js

Harbormaster completed remote builds in B32740: Diff 45914.Nov 20 2024, 7:34 PM

Closed by commit rCOMM02cb5b4bee19: [lib] Fix incorrect timestamps for sidebars (authored by ashoat). · Explain WhyFri, Nov 22, 6:13 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM02cb5b4bee19: [lib] Fix incorrect timestamps for sidebars.

ashoat added a reverting change: rCOMMf7172048c7fe: Revert "[lib] Fix incorrect timestamps for sidebars".Tue, Dec 10, 8:24 AM

ashoat reopened this revision.Tue, Dec 10, 8:25 AM

ashoat added a parent revision: D13916: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.

ashoat added a child revision: D13918: [lib] Reactions only bump thread timestamps when reacting to viewer.

This revision is now accepted and ready to land.Tue, Dec 10, 8:25 AM

Rebase

Harbormaster completed remote builds in B32989: Diff 46295.Tue, Dec 10, 9:27 AM

ashoat added a child revision: D14136: [lib] Don't construct promises in useCreateChatThreadItem.Wed, Dec 11, 3:43 PM