HomePhabricator
Diffusion Comm 02cb5b4bee19

[lib] Fix incorrect timestamps for sidebars

Description

[lib] Fix incorrect timestamps for sidebars

Summary:
This addresses ENG-9951:

  1. Fixes useSidebarInfos's initial ordering to sort on lastUpdatedAtLeastTime (a number) instead of lastUpdatedTime (a promise). Flow failed to catch this because Lodash's usage is hard to type.
  2. Fixes lastUpdatedTimeIncludingSidebars to consider all sidebars, instead of trusting the first one in the initial order to have the most recent timestamp.
  3. Fixes getAllFinalSidebarItems to reorder after all promises resolve.

Test Plan: Tested on both native (my iOS device running a Release build pointed at prod) and web (my comm.software staging environment that uses prod data)

Reviewers: varun, will

Reviewed By: will

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D13984

Details

Provenance
ashoatAuthored on Wed, Nov 20, 8:59 AM
Reviewer
will
Differential Revision
D13984: [lib] Fix incorrect timestamps for sidebars
Parents
rCOMM4d11d51c931e: [lib] Don't query Neynar for Farcaster channel avatars if unused
Branches
Unknown
Tags
Unknown