Page MenuHomePhabricator

[lib] Use ChatThreadItemLoaderCache for loading sidebar
ClosedPublic

Authored by ashoat on Thu, Dec 12, 7:48 PM.
Tags
None
Referenced Files
F3512891: D14154.id46399.diff
Sat, Dec 21, 8:38 PM
F3510984: D14154.id46447.diff
Sat, Dec 21, 12:48 PM
Unknown Object (File)
Fri, Dec 20, 6:56 PM
Unknown Object (File)
Fri, Dec 20, 12:49 PM
Unknown Object (File)
Fri, Dec 20, 8:56 AM
Unknown Object (File)
Thu, Dec 19, 8:21 PM
Unknown Object (File)
Thu, Dec 19, 9:54 AM
Unknown Object (File)
Wed, Dec 18, 9:12 PM
Subscribers
None

Details

Summary

We have the same problem for sidebars that we have at the parent level, especially for the "Daily updates" channel, which has close to 1000 sidebars inside of it.

We need to avoid creating a Promise for each sidebar. We can use ChatThreadItemLoaderCache to achieve this.

Depends on D14144

Test Plan

I tested this task by playing around with the ChatThreadList on mobile while using a stopwatch to measure how long various operations took. I tested the updated code 3 times against both the most recent Testflight build as well as master. I found that performance was approximately the same as before. I tested scrolling down, selecting threads that were read, selecting threads that were unread, and search.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable