Page MenuHomePhabricator

[native] Handle rendering "No messages" inside MessagePreview
ClosedPublic

Authored by ashoat on Oct 30 2024, 11:43 AM.
Tags
None
Referenced Files
F6082425: D13825.id45475.diff
Sun, Apr 20, 10:17 PM
F6051700: D13825.diff
Sun, Apr 20, 6:13 AM
F6045002: D13825.diff
Sun, Apr 20, 3:54 AM
Unknown Object (File)
Sat, Apr 19, 12:52 AM
Unknown Object (File)
Sat, Apr 19, 12:52 AM
Unknown Object (File)
Sat, Apr 19, 12:52 AM
Unknown Object (File)
Wed, Apr 16, 5:00 PM
Unknown Object (File)
Mar 17 2025, 8:35 PM
Subscribers
None

Details

Summary

This matches behavior on web and makes a later diff a bit cleaner.

Depends on D13824

Test Plan

Flow, and tested in combination with the rest of the stack:

  1. Make sure membership operations (user joining / leaving) don't appear in MessagePreview
  2. Make sure reactions to the viewer's messages still appear in MessagePreview
  3. Make sure reactions to other user's messages don't appear in MessagePreview
  4. Test fresh login to thread with only one message in the last 14 days, which is a reaction to a non-viewer message. Make sure the reaction initially appears in MessagePreview, but then is replaced after more messages are fetched by the client

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable