Page MenuHomePhabricator
Differential D13827

[lib] Introduce MessageSpec.showInMessagePreview
ClosedPublic
Actions

Authored by ashoat on Wed, Oct 30, 11:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 7:20 AM
Unknown Object (File)
Wed, Nov 13, 3:13 AM
Unknown Object (File)
Mon, Nov 11, 1:54 PM
Unknown Object (File)
Sun, Nov 10, 11:00 PM
Unknown Object (File)
Sun, Nov 10, 10:27 AM
Unknown Object (File)
Fri, Nov 8, 4:42 AM
Unknown Object (File)
Thu, Nov 7, 12:05 PM
Unknown Object (File)
Thu, Nov 7, 7:24 AM
View All 21 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMM726d17a73e0f: [lib] Introduce MessageSpec.showInMessagePreview
Summary

This diff introduces a generic way to support ENG-9556.

Depends on D13826

Test Plan

Tested in combination with the rest of the stack:

  1. Make sure membership operations (user joining / leaving) don't appear in MessagePreview
  2. Make sure reactions to the viewer's messages still appear in MessagePreview
  3. Make sure reactions to other user's messages don't appear in MessagePreview
  4. Test fresh login to thread with only one message in the last 14 days, which is a reaction to a non-viewer message. Make sure the reaction initially appears in MessagePreview, but then is replaced after more messages are fetched by the client

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Wed, Oct 30, 11:46 AM
ashoat added a child revision: D13828: [lib] Only show reactions to viewer's messages in MessagePreview.
ashoat added inline comments.Wed, Oct 30, 11:56 AM
lib/shared/messages/multimedia-message-spec.js
373–374 ↗(On Diff #45477)

See here for an explanation on this change

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Oct 30, 12:45 PM
Harbormaster failed remote builds in B32444: Diff 45477!
Harbormaster completed remote builds in B32444: Diff 45477.Wed, Oct 30, 1:40 PM
ashoat requested review of this revision.Wed, Oct 30, 1:40 PM
tomek accepted this revision.Thu, Oct 31, 5:56 AM
This revision is now accepted and ready to land.Thu, Oct 31, 5:56 AM
ashoat mentioned this in D13826: [lib] Fetch message to preview from MessagePreview.Thu, Oct 31, 6:09 AM
ashoat removed a child revision: D13828: [lib] Only show reactions to viewer's messages in MessagePreview.Thu, Oct 31, 11:09 AM
ashoat added a child revision: D13830: [lib][native][web] Ignore showInMessagePreview if no messages found.
Closed by commit rCOMM726d17a73e0f: [lib] Introduce MessageSpec.showInMessagePreview (authored by ashoat). · Explain WhyThu, Oct 31, 11:38 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM726d17a73e0f: [lib] Introduce MessageSpec.showInMessagePreview.

Revision Contents
Changeset List

PathSize
lib/
hooks/
27 lines
shared/
messages/
10 lines
3 lines

Diff 45542

View Options

lib/hooks/message-hooks.js

Loading...
View Options

lib/shared/messages/message-spec.js

Loading...
View Options

lib/shared/messages/multimedia-message-spec.js

Loading...