Page MenuHomePhabricator

[native] Add loading indicator at the bottom of ChatThreadList
ClosedPublic

Authored by ashoat on Wed, Dec 11, 3:51 PM.
Tags
None
Referenced Files
F3511034: D14143.id46445.diff
Sat, Dec 21, 1:12 PM
F3509726: D14143.id46369.diff
Sat, Dec 21, 7:42 AM
F3509329: D14143.id46362.diff
Sat, Dec 21, 3:33 AM
Unknown Object (File)
Fri, Dec 20, 7:17 PM
Unknown Object (File)
Fri, Dec 20, 9:49 AM
Unknown Object (File)
Fri, Dec 20, 12:29 AM
Unknown Object (File)
Thu, Dec 19, 10:38 PM
Unknown Object (File)
Thu, Dec 19, 6:04 PM
Subscribers
None

Details

Summary

Now that loading is async and can take a bit longer, it's good to have a loading indicator visible to the user.

Depends on D14142

Test Plan

I tested this task by playing around with the ChatThreadList on mobile while using a stopwatch to measure how long various operations took. I tested the updated code 3 times against both the most recent Testflight build as well as master. I found that performance was approximately the same as before. I tested scrolling down, selecting threads that were read, selecting threads that were unread, and search.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable