Differential D13824

[lib] Inline createChatThreadItem
ClosedPublic
Actions

Authored by ashoat on Oct 30 2024, 11:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 20, 12:59 AM

	Unknown Object (File)
	Sat, Apr 19, 12:52 AM

	Unknown Object (File)
	Sat, Apr 19, 12:52 AM

	Unknown Object (File)
	Sat, Apr 19, 12:52 AM

	Unknown Object (File)
	Wed, Apr 16, 4:59 PM

	Unknown Object (File)
	Tue, Apr 8, 5:13 PM

	Unknown Object (File)
	Mar 11 2025, 3:54 PM

	Unknown Object (File)
	Feb 22 2025, 9:51 PM

View All 63 Files

Subscribers

None

Details

Reviewers

Commits

rCOMMfd009c90168e: [lib] Inline createChatThreadItem

Summary

Now that it's only called from one place, we can reduce the indirection by inlining it.

Depends on D13823

Test Plan

Flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 30 2024, 11:42 AM

ashoat added a child revision: D13825: [native] Handle rendering "No messages" inside MessagePreview.

Harbormaster completed remote builds in B32441: Diff 45474.Oct 30 2024, 12:16 PM

ashoat requested review of this revision.Oct 30 2024, 12:16 PM

tomek accepted this revision.Oct 31 2024, 5:35 AM

This revision is now accepted and ready to land.Oct 31 2024, 5:35 AM

Closed by commit rCOMMfd009c90168e: [lib] Inline createChatThreadItem (authored by ashoat). · Explain WhyOct 31 2024, 11:38 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMfd009c90168e: [lib] Inline createChatThreadItem.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

chat-selectors.js

157 lines

Diff 45539

lib/selectors/chat-selectors.js

	Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines		OlmPersistSession persistSession = {
	it->first,			it->first,
	std::string(it->second.buffer.begin(), it->second.buffer.end()),			std::string(it->second.buffer.begin(), it->second.buffer.end()),
	it->second.version};			it->second.version};

	this->storeOlmPersistSession(persistSession);			this->storeOlmPersistSession(persistSession);
	}			}
	}			}

	void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
	this->setMetadata("notify_token", token);
	}

	void SQLiteQueryExecutor::clearNotifyToken() const {
	this->clearMetadata("notify_token");
	}

	void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {			void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
	this->setMetadata("current_user_id", userID);			this->setMetadata("current_user_id", userID);
	}			}

	std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {			std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
	return this->getMetadata("current_user_id");			return this->getMetadata("current_user_id");
	}			}

	▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines