Page MenuHomePhabricator
Differential D13822

[web] Convert activeChatThreadItem to a hook
ClosedPublic
Actions

Authored by ashoat on Wed, Oct 30, 11:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 3:50 PM
Unknown Object (File)
Sat, Nov 16, 9:54 AM
Unknown Object (File)
Thu, Nov 14, 8:04 PM
Unknown Object (File)
Thu, Nov 14, 1:04 PM
Unknown Object (File)
Mon, Nov 11, 5:59 AM
Unknown Object (File)
Mon, Nov 11, 12:11 AM
Unknown Object (File)
Sun, Nov 10, 1:53 PM
Unknown Object (File)
Sun, Nov 10, 11:00 AM
View All 23 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMMcad0197a05f5: [web] Convert activeChatThreadItem to a hook
Summary

This will make the next diff a little easier.

Depends on D13821

Test Plan

Flow, and tested in combination with the rest of the stack:

  1. Make sure membership operations (user joining / leaving) don't appear in MessagePreview
  2. Make sure reactions to the viewer's messages still appear in MessagePreview
  3. Make sure reactions to other user's messages don't appear in MessagePreview
  4. Test fresh login to thread with only one message in the last 14 days, which is a reaction to a non-viewer message. Make sure the reaction initially appears in MessagePreview, but then is replaced after more messages are fetched by the client

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Wed, Oct 30, 11:39 AM
ashoat added a child revision: D13823: [lib][web] Introduce useCreateChatThreadItem.
Harbormaster completed remote builds in B32439: Diff 45472.Wed, Oct 30, 11:59 AM
ashoat requested review of this revision.Wed, Oct 30, 11:59 AM
tomek accepted this revision.Thu, Oct 31, 5:26 AM
tomek added inline comments.
web/selectors/chat-selectors.js
57–65 ↗(On Diff #45472)

It seems like we could use useChatThreadItem here

This revision is now accepted and ready to land.Thu, Oct 31, 5:26 AM
ashoat updated this revision to Diff 45530.Thu, Oct 31, 11:23 AM

Reuse useChatThreadItem

web/selectors/chat-selectors.js
57–65 ↗(On Diff #45472)

Good call!

This revision was landed with ongoing or failed builds.Thu, Oct 31, 11:38 AM
Closed by commit rCOMMcad0197a05f5: [web] Convert activeChatThreadItem to a hook (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMcad0197a05f5: [web] Convert activeChatThreadItem to a hook.
Harbormaster completed remote builds in B32496: Diff 45530.Thu, Oct 31, 11:41 AM

Revision Contents
Changeset List

PathSize
web/
avatars/
5 lines
chat/
4 lines
selectors/
61 lines

Diff 45537

View Options

web/avatars/web-edit-thread-avatar-provider.react.js

Loading...
View Options

web/chat/thread-list-provider.js

Loading...
View Options

web/selectors/chat-selectors.js

Loading...