Page MenuHomePhabricator
Differential D13914

[lib] Extract getSidebarItems
ClosedPublic
Actions

Authored by ashoat on Nov 12 2024, 12:42 PM.
Tags
None
Referenced Files
F6089148: D13914.id45807.diff
Mon, Apr 21, 1:02 AM
F6088046: D13914.id.diff
Mon, Apr 21, 12:37 AM
F6085516: D13914.id46432.diff
Sun, Apr 20, 11:41 PM
F6082838: D13914.id45768.diff
Sun, Apr 20, 10:41 PM
F6053631: D13914.diff
Sun, Apr 20, 6:39 AM
Unknown Object (File)
Mon, Apr 14, 10:00 AM
Unknown Object (File)
Mar 11 2025, 4:16 PM
Unknown Object (File)
Mar 11 2025, 4:07 PM
View All Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMM381a55bb9bb9: [lib] Extract getSidebarItems
rCOMM481690308381: [lib] Extract getSidebarItems
Summary

This will make a following diff a little easier.

Depends on D13913

Test Plan

Flow. Also tested in combination with the rest of the stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 12 2024, 12:42 PM
ashoat added a child revision: D13915: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.
ashoat updated this revision to Diff 45768.Nov 12 2024, 12:56 PM

Rebase

Harbormaster failed remote builds in B32625: Diff 45761!Nov 12 2024, 1:09 PM
Harbormaster completed remote builds in B32632: Diff 45768.Nov 12 2024, 2:18 PM
ashoat requested review of this revision.Nov 12 2024, 2:18 PM
tomek accepted this revision.Nov 13 2024, 4:13 AM
This revision is now accepted and ready to land.Nov 13 2024, 4:13 AM
Closed by commit rCOMM481690308381: [lib] Extract getSidebarItems (authored by ashoat). · Explain WhyNov 13 2024, 11:20 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM481690308381: [lib] Extract getSidebarItems.
ashoat added a reverting change: rCOMMd5b919ba29cf: Revert "[lib] Extract getSidebarItems".Dec 10 2024, 8:24 AM
ashoat reopened this revision.Dec 10 2024, 8:24 AM
This revision is now accepted and ready to land.Dec 10 2024, 8:24 AM
ashoat updated this revision to Diff 46292.Dec 10 2024, 8:27 AM

Rebase

Harbormaster completed remote builds in B32986: Diff 46292.Dec 10 2024, 8:57 AM
Closed by commit rCOMM381a55bb9bb9: [lib] Extract getSidebarItems (authored by ashoat). · Explain WhyDec 13 2024, 6:13 AM
This revision was automatically updated to reflect the committed changes.
Ashoat Tevosyan <ashoat@gmail.com> added a commit: rCOMM381a55bb9bb9: [lib] Extract getSidebarItems.

Revision Contents
Changeset List

PathSize
lib/
selectors/
63 lines
shared/
68 lines
6 lines

Diff 46432

View Options

lib/selectors/chat-selectors.js

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines
View Options

lib/shared/sidebar-item-utils.js

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines
View Options

lib/shared/thread-utils.js

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines