Page MenuHomePhabricator

[lib][native] Update native to use ChatThreadItemLoaderCache
ClosedPublic

Authored by ashoat on Dec 11 2024, 3:50 PM.
Tags
None
Referenced Files
F6051673: D14141.diff
Sun, Apr 20, 6:12 AM
Unknown Object (File)
Tue, Apr 8, 4:37 PM
Unknown Object (File)
Wed, Apr 2, 11:53 AM
Unknown Object (File)
Mar 6 2025, 2:52 PM
Unknown Object (File)
Feb 26 2025, 4:45 AM
Unknown Object (File)
Feb 26 2025, 4:44 AM
Unknown Object (File)
Feb 25 2025, 4:29 AM
Unknown Object (File)
Feb 18 2025, 10:21 AM
Subscribers
None

Details

Summary

By using ChatThreadItemLoaderCache, we avoid overwhelming Hermes with Promises (context here).

Depends on D14140

Test Plan

I tested this task by playing around with the ChatThreadList on mobile while using a stopwatch to measure how long various operations took. I tested the updated code 3 times against both the most recent Testflight build as well as master. I found that performance was approximately the same as before. I tested scrolling down, selecting threads that were read, selecting threads that were unread, and search.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable