Page MenuHomePhabricator

[lib][native] Update native to use ChatThreadItemLoaderCache
ClosedPublic

Authored by ashoat on Wed, Dec 11, 3:50 PM.
Tags
None
Referenced Files
F3513809: D14141.diff
Sun, Dec 22, 2:17 AM
F3511185: D14141.id46360.diff
Sat, Dec 21, 1:39 PM
F3510032: D14141.id46442.diff
Sat, Dec 21, 10:44 AM
F3509971: D14141.id46397.diff
Sat, Dec 21, 9:51 AM
Unknown Object (File)
Sat, Dec 21, 2:03 AM
Unknown Object (File)
Fri, Dec 20, 12:44 PM
Unknown Object (File)
Fri, Dec 20, 6:44 AM
Unknown Object (File)
Fri, Dec 20, 5:36 AM
Subscribers
None

Details

Summary

By using ChatThreadItemLoaderCache, we avoid overwhelming Hermes with Promises (context here).

Depends on D14140

Test Plan

I tested this task by playing around with the ChatThreadList on mobile while using a stopwatch to measure how long various operations took. I tested the updated code 3 times against both the most recent Testflight build as well as master. I found that performance was approximately the same as before. I tested scrolling down, selecting threads that were read, selecting threads that were unread, and search.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage