Page MenuHomePhabricator

[lib] Hide membership robotext from MessagePreview in thin threads
ClosedPublic

Authored by ashoat on Oct 30 2024, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 24, 11:26 PM
Unknown Object (File)
Tue, Mar 18, 5:00 AM
Unknown Object (File)
Sat, Mar 15, 4:25 PM
Unknown Object (File)
Thu, Mar 13, 2:43 AM
Unknown Object (File)
Wed, Mar 12, 10:27 PM
Unknown Object (File)
Tue, Mar 11, 3:47 PM
Unknown Object (File)
Tue, Mar 11, 3:41 PM
Unknown Object (File)
Tue, Mar 11, 3:41 PM
Subscribers
None

Details

Summary

Part of addressing ENG-9556.

This diff makes it so that in thin threads, we don't show robotext about users joining/leaving/being added/being removed in MessagePreview on both web and native.

Depends on D13828

Test Plan

Tested in combination with the rest of the stack:

  1. Make sure membership operations (user joining / leaving) don't appear in MessagePreview
  2. Make sure reactions to the viewer's messages still appear in MessagePreview
  3. Make sure reactions to other user's messages don't appear in MessagePreview
  4. Test fresh login to thread with only one message in the last 14 days, which is a reaction to a non-viewer message. Make sure the reaction initially appears in MessagePreview, but then is replaced after more messages are fetched by the client

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lib/shared/messages/add-members-message-spec.js
233 โ†—(On Diff #45479)

Flow didn't like when I tried checking params.threadInfo.thick instead

tomek added inline comments.
lib/shared/messages/add-members-message-spec.js
233 โ†—(On Diff #45479)

That's because only RawThreadInfo has this property. ThreadInfo doesn't have it.

This revision is now accepted and ready to land.Oct 31 2024, 6:06 AM