Page MenuHomePhabricator
Differential D13829

[lib] Hide membership robotext from MessagePreview in thin threads
ClosedPublic
Actions

Authored by ashoat on Oct 30 2024, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 12:32 PM
Unknown Object (File)
Sat, Apr 19, 12:30 PM
Unknown Object (File)
Sat, Apr 19, 9:13 AM
Unknown Object (File)
Sat, Apr 19, 7:50 AM
Unknown Object (File)
Fri, Apr 18, 9:48 PM
Unknown Object (File)
Fri, Apr 18, 6:55 PM
Unknown Object (File)
Fri, Apr 18, 2:39 AM
Unknown Object (File)
Wed, Apr 16, 5:02 PM
View All 95 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMM66e1ed36f86f: [lib] Hide membership robotext from MessagePreview in thin threads
Summary

Part of addressing ENG-9556.

This diff makes it so that in thin threads, we don't show robotext about users joining/leaving/being added/being removed in MessagePreview on both web and native.

Depends on D13828

Test Plan

Tested in combination with the rest of the stack:

  1. Make sure membership operations (user joining / leaving) don't appear in MessagePreview
  2. Make sure reactions to the viewer's messages still appear in MessagePreview
  3. Make sure reactions to other user's messages don't appear in MessagePreview
  4. Test fresh login to thread with only one message in the last 14 days, which is a reaction to a non-viewer message. Make sure the reaction initially appears in MessagePreview, but then is replaced after more messages are fetched by the client

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 30 2024, 11:48 AM
ashoat added a child revision: D13830: [lib][native][web] Ignore showInMessagePreview if no messages found.
ashoat added inline comments.Oct 30 2024, 11:58 AM
lib/shared/messages/add-members-message-spec.js
233 ↗(On Diff #45479)

Flow didn't like when I tried checking params.threadInfo.thick instead

Harbormaster completed remote builds in B32446: Diff 45479.Oct 30 2024, 1:05 PM
ashoat requested review of this revision.Oct 30 2024, 1:05 PM
tomek accepted this revision.Oct 31 2024, 6:06 AM
tomek added inline comments.
lib/shared/messages/add-members-message-spec.js
233 ↗(On Diff #45479)

That's because only RawThreadInfo has this property. ThreadInfo doesn't have it.

This revision is now accepted and ready to land.Oct 31 2024, 6:06 AM
ashoat removed a child revision: D13830: [lib][native][web] Ignore showInMessagePreview if no messages found.Oct 31 2024, 11:08 AM
ashoat added a child revision: D13910: [lib] Inline getMostRecentMessageInfo.Nov 12 2024, 12:39 PM
ashoat mentioned this in D13919: [lib] Don't bump thin thread timestamp for membership robotext.Nov 12 2024, 12:47 PM
ashoat removed a child revision: D13910: [lib] Inline getMostRecentMessageInfo.Dec 11 2024, 3:30 PM
ashoat added a child revision: D13918: [lib] Reactions only bump thread timestamps when reacting to viewer.Dec 11 2024, 3:54 PM
ashoat updated this revision to Diff 46364.Dec 11 2024, 3:57 PM

Rebase

Harbormaster completed remote builds in B33046: Diff 46364.Dec 11 2024, 5:09 PM
ashoat updated this revision to Diff 46904.Feb 4 2025, 8:21 PM

Rebase

Harbormaster failed remote builds in B33385: Diff 46904!Feb 4 2025, 8:33 PM
ashoat updated this revision to Diff 46927.Feb 5 2025, 6:08 PM

Rebase

Harbormaster completed remote builds in B33400: Diff 46927.Feb 5 2025, 6:28 PM
Closed by commit rCOMM66e1ed36f86f: [lib] Hide membership robotext from MessagePreview in thin threads (authored by ashoat). · Explain WhyFeb 12 2025, 5:59 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM66e1ed36f86f: [lib] Hide membership robotext from MessagePreview in thin threads.
ashoat mentioned this in rCOMMed4a7ace58be: [lib] Don't bump thin thread timestamp for membership robotext.

Revision Contents
Changeset List

Diff 47040

View Options

lib/shared/messages/add-members-message-spec.js

Show All 16 LinesIntegrityStore::IntegrityStore(
std::shared_ptr<facebook::react::CallInvoker> jsInvoker) std::shared_ptr<facebook::react::CallInvoker> jsInvoker)
: BaseDataStore(jsInvoker) { : BaseDataStore(jsInvoker) {
} }
jsi::Array IntegrityStore::parseDBDataStore( jsi::Array IntegrityStore::parseDBDataStore(
jsi::Runtime &rt, jsi::Runtime &rt,
std::shared_ptr<std::vector<IntegrityThreadHash>> std::shared_ptr<std::vector<IntegrityThreadHash>>
integrityThreadHashesVectorPtr) const { integrityThreadHashesVectorPtr) const {
jsi::Array jsiIntegrityThreadHashes = jsi::Array(rt, 0); size_t numIntegrityThreadHashes = integrityThreadHashesVectorPtr->size();
jsi::Array jsiIntegrityThreadHashes =
jsi::Array(rt, numIntegrityThreadHashes);
size_t writeIdx = 0;
for (const IntegrityThreadHash &integrityThreadHash :
*integrityThreadHashesVectorPtr) {
jsi::Object jsiIntegrityThreadHash = jsi::Object(rt);
jsiIntegrityThreadHash.setProperty(rt, "id", integrityThreadHash.id);
jsiIntegrityThreadHash.setProperty(
rt, "threadHash", integrityThreadHash.thread_hash);
jsiIntegrityThreadHashes.setValueAtIndex(
rt, writeIdx++, jsiIntegrityThreadHash);
}
return jsiIntegrityThreadHashes; return jsiIntegrityThreadHashes;
} }
std::vector<std::unique_ptr<IntegrityStoreOperationBase>> std::vector<std::unique_ptr<IntegrityStoreOperationBase>>
IntegrityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations) IntegrityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const { const {
std::vector<std::unique_ptr<IntegrityStoreOperationBase>> integrityStoreOps; std::vector<std::unique_ptr<IntegrityStoreOperationBase>> integrityStoreOps;
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines
View Options

lib/shared/messages/join-thread-message-spec.js

Show All 16 LinesIntegrityStore::IntegrityStore(
std::shared_ptr<facebook::react::CallInvoker> jsInvoker) std::shared_ptr<facebook::react::CallInvoker> jsInvoker)
: BaseDataStore(jsInvoker) { : BaseDataStore(jsInvoker) {
} }
jsi::Array IntegrityStore::parseDBDataStore( jsi::Array IntegrityStore::parseDBDataStore(
jsi::Runtime &rt, jsi::Runtime &rt,
std::shared_ptr<std::vector<IntegrityThreadHash>> std::shared_ptr<std::vector<IntegrityThreadHash>>
integrityThreadHashesVectorPtr) const { integrityThreadHashesVectorPtr) const {
jsi::Array jsiIntegrityThreadHashes = jsi::Array(rt, 0); size_t numIntegrityThreadHashes = integrityThreadHashesVectorPtr->size();
jsi::Array jsiIntegrityThreadHashes =
jsi::Array(rt, numIntegrityThreadHashes);
size_t writeIdx = 0;
for (const IntegrityThreadHash &integrityThreadHash :
*integrityThreadHashesVectorPtr) {
jsi::Object jsiIntegrityThreadHash = jsi::Object(rt);
jsiIntegrityThreadHash.setProperty(rt, "id", integrityThreadHash.id);
jsiIntegrityThreadHash.setProperty(
rt, "threadHash", integrityThreadHash.thread_hash);
jsiIntegrityThreadHashes.setValueAtIndex(
rt, writeIdx++, jsiIntegrityThreadHash);
}
return jsiIntegrityThreadHashes; return jsiIntegrityThreadHashes;
} }
std::vector<std::unique_ptr<IntegrityStoreOperationBase>> std::vector<std::unique_ptr<IntegrityStoreOperationBase>>
IntegrityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations) IntegrityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const { const {
std::vector<std::unique_ptr<IntegrityStoreOperationBase>> integrityStoreOps; std::vector<std::unique_ptr<IntegrityStoreOperationBase>> integrityStoreOps;
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines
View Options

lib/shared/messages/leave-thread-message-spec.js

Show All 16 LinesIntegrityStore::IntegrityStore(
std::shared_ptr<facebook::react::CallInvoker> jsInvoker) std::shared_ptr<facebook::react::CallInvoker> jsInvoker)
: BaseDataStore(jsInvoker) { : BaseDataStore(jsInvoker) {
} }
jsi::Array IntegrityStore::parseDBDataStore( jsi::Array IntegrityStore::parseDBDataStore(
jsi::Runtime &rt, jsi::Runtime &rt,
std::shared_ptr<std::vector<IntegrityThreadHash>> std::shared_ptr<std::vector<IntegrityThreadHash>>
integrityThreadHashesVectorPtr) const { integrityThreadHashesVectorPtr) const {
jsi::Array jsiIntegrityThreadHashes = jsi::Array(rt, 0); size_t numIntegrityThreadHashes = integrityThreadHashesVectorPtr->size();
jsi::Array jsiIntegrityThreadHashes =
jsi::Array(rt, numIntegrityThreadHashes);
size_t writeIdx = 0;
for (const IntegrityThreadHash &integrityThreadHash :
*integrityThreadHashesVectorPtr) {
jsi::Object jsiIntegrityThreadHash = jsi::Object(rt);
jsiIntegrityThreadHash.setProperty(rt, "id", integrityThreadHash.id);
jsiIntegrityThreadHash.setProperty(
rt, "threadHash", integrityThreadHash.thread_hash);
jsiIntegrityThreadHashes.setValueAtIndex(
rt, writeIdx++, jsiIntegrityThreadHash);
}
return jsiIntegrityThreadHashes; return jsiIntegrityThreadHashes;
} }
std::vector<std::unique_ptr<IntegrityStoreOperationBase>> std::vector<std::unique_ptr<IntegrityStoreOperationBase>>
IntegrityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations) IntegrityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const { const {
std::vector<std::unique_ptr<IntegrityStoreOperationBase>> integrityStoreOps; std::vector<std::unique_ptr<IntegrityStoreOperationBase>> integrityStoreOps;
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines
View Options

lib/shared/messages/remove-members-message-spec.js

Show All 16 LinesIntegrityStore::IntegrityStore(
std::shared_ptr<facebook::react::CallInvoker> jsInvoker) std::shared_ptr<facebook::react::CallInvoker> jsInvoker)
: BaseDataStore(jsInvoker) { : BaseDataStore(jsInvoker) {
} }
jsi::Array IntegrityStore::parseDBDataStore( jsi::Array IntegrityStore::parseDBDataStore(
jsi::Runtime &rt, jsi::Runtime &rt,
std::shared_ptr<std::vector<IntegrityThreadHash>> std::shared_ptr<std::vector<IntegrityThreadHash>>
integrityThreadHashesVectorPtr) const { integrityThreadHashesVectorPtr) const {
jsi::Array jsiIntegrityThreadHashes = jsi::Array(rt, 0); size_t numIntegrityThreadHashes = integrityThreadHashesVectorPtr->size();
jsi::Array jsiIntegrityThreadHashes =
jsi::Array(rt, numIntegrityThreadHashes);
size_t writeIdx = 0;
for (const IntegrityThreadHash &integrityThreadHash :
*integrityThreadHashesVectorPtr) {
jsi::Object jsiIntegrityThreadHash = jsi::Object(rt);
jsiIntegrityThreadHash.setProperty(rt, "id", integrityThreadHash.id);
jsiIntegrityThreadHash.setProperty(
rt, "threadHash", integrityThreadHash.thread_hash);
jsiIntegrityThreadHashes.setValueAtIndex(
rt, writeIdx++, jsiIntegrityThreadHash);
}
return jsiIntegrityThreadHashes; return jsiIntegrityThreadHashes;
} }
std::vector<std::unique_ptr<IntegrityStoreOperationBase>> std::vector<std::unique_ptr<IntegrityStoreOperationBase>>
IntegrityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations) IntegrityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const { const {
std::vector<std::unique_ptr<IntegrityStoreOperationBase>> integrityStoreOps; std::vector<std::unique_ptr<IntegrityStoreOperationBase>> integrityStoreOps;
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines