Page MenuHomePhabricator
Differential D14337

[keyserver] Only bump last_message_for_unread_check for certain message types
ClosedPublic
Actions

Authored by ashoat on Feb 11 2025, 12:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 22, 9:05 AM
Unknown Object (File)
Mon, Mar 17, 9:41 PM
Unknown Object (File)
Mon, Mar 17, 9:33 PM
Unknown Object (File)
Fri, Mar 14, 6:15 AM
Unknown Object (File)
Fri, Mar 14, 5:11 AM
Unknown Object (File)
Fri, Mar 14, 5:03 AM
Unknown Object (File)
Fri, Mar 14, 4:38 AM
Unknown Object (File)
Fri, Mar 14, 4:29 AM
View All 45 Files
Subscribers
None

Details

Reviewers
tomek
angelika
Commits
rCOMM1c344b3d76e4: [keyserver] Only bump last_message_for_unread_check for certain message types
Summary

This diff makes it so for keyserver-hosted messages, we only bump last_message_for_unread_check for messageNotifyTypes.SET_UNREAD and messageNotifyTypes.NOTIF_AND_SET_UNREAD.

It has the immediate effect of preventing last_message_for_unread_check from being bumped for messageNotifyTypes.RESCIND, which is used for un-reacts to an author's message.

In later diffs we will introduce messageNotifyTypes.NONE to several message specs, which will achieve ENG-9557.

Depends on D14336

Test Plan

In combination with later diffs, tested the following for a thin thread:

  1. Log in as two users, one on iOS and one on Android
  2. On iOS, bump an unrelated thread not used for testing, so the testing thread is not the latest
  3. On Android, react to a message authored by the Android user in the testing thread. Confirm that on iOS, the thread does not appear as unread, it is not bumped in the thread list, and the MessagePreview does not update
  4. Do the same while the iOS app is backgrounded, and confirm a notif is not generated
  5. Do steps 2-4 again, but this time on Android react to a message authored by the iOS user. Confirm that the thread appears unread, is bumped in the thread list, the MessagePreview updates, and a notif is sent (if the iOS app is backgrounded)
  6. Test adding a user, removing a user, having a user leave, and having a user join. Confirm that these actions don't make the thread appear as unread

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 11 2025, 12:19 AM
ashoat added a child revision: D14339: [lib] Fix DM push notifs code to fetch message from SQLite instead of Redux.Feb 11 2025, 12:22 AM
ashoat mentioned this in D14344: [lib] Don't set thread to unread for reactions to other user's messages.Feb 11 2025, 12:28 AM
ashoat mentioned this in D14345: [lib] Don't set thread to unread for membership robotext in thin threads.
Harbormaster completed remote builds in B33453: Diff 46985.Feb 11 2025, 1:23 AM
ashoat requested review of this revision.Feb 11 2025, 1:23 AM
tomek accepted this revision.Feb 11 2025, 9:29 AM
This revision is now accepted and ready to land.Feb 11 2025, 9:29 AM
Closed by commit rCOMM1c344b3d76e4: [keyserver] Only bump last_message_for_unread_check for certain message types (authored by ashoat). · Explain WhyFeb 12 2025, 5:59 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM1c344b3d76e4: [keyserver] Only bump last_message_for_unread_check for certain message types.
ashoat mentioned this in rCOMMea97d13b0d77: [lib] Don't set thread to unread for reactions to other user's messages.
ashoat mentioned this in rCOMM9e5875ab6a75: [lib] Don't set thread to unread for membership robotext in thin threads.

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
18 lines

Diff 47033

View Options

keyserver/src/creators/message-creator.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
parseThreadPermissionString, parseThreadPermissionString,
constructThreadPermissionString,
includeThreadPermissionForThreadType, includeThreadPermissionForThreadType,
} from './prefixes.js'; } from './prefixes.js';
import { import {
configurableCommunityPermissions, configurableCommunityPermissions,
threadPermissionFilterPrefixes, threadPermissionFilterPrefixes,
threadPermissionPropagationPrefixes, threadPermissionPropagationPrefixes,
threadPermissions, threadPermissions,
userSurfacedPermissions, userSurfacedPermissions,
▲ Show 20 Lines • Show All 148 Lines • ▼ Show 20 Lines if (!parsed.propagationPrefix) {
continue; continue;
} }
if ( if (
parsed.propagationPrefix === parsed.propagationPrefix ===
threadPermissionPropagationPrefixes.DESCENDANT threadPermissionPropagationPrefixes.DESCENDANT
) { ) {
permissionsForChildren[permissionKey] = permissionValue; permissionsForChildren[permissionKey] = permissionValue;
} }
const permissionWithFilterPrefix = parsed.filterPrefix const withoutPropagationPrefix = constructThreadPermissionString({
? `${parsed.filterPrefix}${parsed.permission}` ...parsed,
: parsed.permission; propagationPrefix: null,
permissionsForChildren[permissionWithFilterPrefix] = permissionValue; });
permissionsForChildren[withoutPropagationPrefix] = permissionValue;
} }
if (Object.keys(permissionsForChildren).length === 0) { if (Object.keys(permissionsForChildren).length === 0) {
return null; return null;
} }
return permissionsForChildren; return permissionsForChildren;
} }
function getRoleForPermissions( function getRoleForPermissions(
▲ Show 20 Lines • Show All 373 Lines • Show Last 20 Lines