Page MenuHomePhabricator
Differential D14342

[lib] Add messagesNotifyTypes to ProcessDMOpsPayload
ClosedPublic
Actions

Authored by ashoat on Feb 11 2025, 12:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 9:16 PM
Unknown Object (File)
Tue, Mar 11, 4:15 PM
Unknown Object (File)
Tue, Mar 11, 3:55 PM
Unknown Object (File)
Tue, Mar 11, 7:01 AM
Unknown Object (File)
Mon, Mar 3, 2:12 PM
Unknown Object (File)
Mar 1 2025, 4:21 AM
Unknown Object (File)
Feb 28 2025, 2:13 AM
Unknown Object (File)
Feb 28 2025, 2:03 AM
View All 36 Files
Subscribers
None

Details

Reviewers
tomek
angelika
Commits
rCOMM114ba23ad0f2: [lib] Add messagesNotifyTypes to ProcessDMOpsPayload
Summary

We want to get access to this data in reducers. Since it requires an await, we need to determine it prior to the dispatch.

Depends on D14341

Test Plan

Tested in combination with later diffs, to confirm that it's possible for some message types to not set a thread to unread

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
126 lines
types/
2 lines

Diff 47037

View Options

lib/shared/dm-ops/process-dm-ops.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines +getInboundKeysForUserDevice: (
authDeviceId: string, authDeviceId: string,
authAccessToken: string, authAccessToken: string,
userId: string, userId: string,
deviceId: string, deviceId: string,
) => Promise<InboundKeyInfoResponse>, ) => Promise<InboundKeyInfoResponse>,
+getFarcasterUsers: ( +getFarcasterUsers: (
farcasterIds: $ReadOnlyArray<string>, farcasterIds: $ReadOnlyArray<string>,
) => Promise<$ReadOnlyArray<FarcasterUser>>, ) => Promise<$ReadOnlyArray<FarcasterUser>>,
+generateNonce: () => Promise<string>,
}; };
export type { RustNativeBindingAPI }; export type { RustNativeBindingAPI };
View Options

lib/types/dm-ops.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines +getInboundKeysForUserDevice: (
authDeviceId: string, authDeviceId: string,
authAccessToken: string, authAccessToken: string,
userId: string, userId: string,
deviceId: string, deviceId: string,
) => Promise<InboundKeyInfoResponse>, ) => Promise<InboundKeyInfoResponse>,
+getFarcasterUsers: ( +getFarcasterUsers: (
farcasterIds: $ReadOnlyArray<string>, farcasterIds: $ReadOnlyArray<string>,
) => Promise<$ReadOnlyArray<FarcasterUser>>, ) => Promise<$ReadOnlyArray<FarcasterUser>>,
+generateNonce: () => Promise<string>,
}; };
export type { RustNativeBindingAPI }; export type { RustNativeBindingAPI };