[lib] Don't set thread to unread for reactions to other user's messages
ClosedPublic
Actions

Authored by ashoat on Feb 11 2025, 12:28 AM.

Details

Reviewers

tomek
angelika

Commits

rCOMMea97d13b0d77: [lib] Don't set thread to unread for reactions to other user's messages

Summary

This addresses part of the goal of ENG-9557.

Note that we'll have to continue setting the thread to unread for reactions to your own messages, as those generate a notif. More context here.

Depends on D14338

Test Plan

See test plans of D14337 (thin threads) and D14343 (thick threads)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 11 2025, 12:28 AM

ashoat added a child revision: D14345: [lib] Don't set thread to unread for membership robotext in thin threads.

ashoat edited the summary of this revision. (Show Details)Feb 11 2025, 12:32 AM

ashoat added a parent revision: D14338: [lib][web] Introduce threadIDIsThick.

ashoat removed a parent revision: D13919: [lib] Don't bump thin thread timestamp for membership robotext.

Harbormaster completed remote builds in B33460: Diff 46992.Feb 11 2025, 2:27 AM

ashoat requested review of this revision.Feb 11 2025, 2:27 AM

tomek accepted this revision.Feb 12 2025, 5:23 AM

This revision is now accepted and ready to land.Feb 12 2025, 5:23 AM

Closed by commit rCOMMea97d13b0d77: [lib] Don't set thread to unread for reactions to other user's messages (authored by ashoat). · Explain WhyFeb 12 2025, 5:59 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMea97d13b0d77: [lib] Don't set thread to unread for reactions to other user's messages.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

reaction-message-spec.js

2 lines

Diff 47044

View Options

lib/shared/messages/reaction-message-spec.js

[lib] Don't set thread to unread for reactions to other user's messagesClosedPublicActions