Page MenuHomePhabricator
Differential D14332

[keyserver] Consider all new messages in determineLatestMessagesPerThread
ClosedPublic
Actions

Authored by ashoat on Feb 11 2025, 12:07 AM.
Tags
None
Referenced Files
F6048895: D14332.id47027.diff
Sun, Apr 20, 5:34 AM
F6047033: D14332.id46980.diff
Sun, Apr 20, 5:11 AM
Unknown Object (File)
Sat, Apr 19, 4:26 AM
Unknown Object (File)
Fri, Apr 18, 11:15 PM
Unknown Object (File)
Thu, Apr 17, 11:30 PM
Unknown Object (File)
Wed, Apr 16, 11:52 AM
Unknown Object (File)
Thu, Apr 3, 6:14 PM
Unknown Object (File)
Wed, Apr 2, 4:43 AM
View All 39 Files
Subscribers
None

Details

Reviewers
tomek
angelika
Commits
rCOMMb5ea24eb7798: [keyserver] Consider all new messages in determineLatestMessagesPerThread
Summary

determineLatestMessagesPerThread currently has a subtle bug due to the fact that it only considers the last message index. (It iterates through all of them, but only the last one matters because it overwrites the results from earlier ones.)

latestMessage is getting set correctly in all cases, but the bug is that latestReadMessage can be wrong in some cases. In particular, if the most recent message doesn't set latestReadMessage, but an earlier one does, then the earlier one will be ignored and latestReadMessage will not be set.

This is a pretty extreme edge case because it only applies in the case that we have messages from different authors in the createMessages call, which I don't believe happens at any current callsites. But it still makes sense to fix the bug, and the issue becomes more relevant in future diffs where we introduce code to set latestMessageForUnreadCheck as well.

Depends on D14331

Test Plan

Tested in combination with later diffs, to confirm that it's possible for some message types to not set a thread to unread

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
18 lines

Diff 47027

View Options

keyserver/src/creators/message-creator.js

Show All 16 LinesIntegrityStore::IntegrityStore(
std::shared_ptr<facebook::react::CallInvoker> jsInvoker) std::shared_ptr<facebook::react::CallInvoker> jsInvoker)
: BaseDataStore(jsInvoker) { : BaseDataStore(jsInvoker) {
} }
jsi::Array IntegrityStore::parseDBDataStore( jsi::Array IntegrityStore::parseDBDataStore(
jsi::Runtime &rt, jsi::Runtime &rt,
std::shared_ptr<std::vector<IntegrityThreadHash>> std::shared_ptr<std::vector<IntegrityThreadHash>>
integrityThreadHashesVectorPtr) const { integrityThreadHashesVectorPtr) const {
jsi::Array jsiIntegrityThreadHashes = jsi::Array(rt, 0); size_t numIntegrityThreadHashes = integrityThreadHashesVectorPtr->size();
jsi::Array jsiIntegrityThreadHashes =
jsi::Array(rt, numIntegrityThreadHashes);
size_t writeIdx = 0;
for (const IntegrityThreadHash &integrityThreadHash :
*integrityThreadHashesVectorPtr) {
jsi::Object jsiIntegrityThreadHash = jsi::Object(rt);
jsiIntegrityThreadHash.setProperty(rt, "id", integrityThreadHash.id);
jsiIntegrityThreadHash.setProperty(
rt, "threadHash", integrityThreadHash.thread_hash);
jsiIntegrityThreadHashes.setValueAtIndex(
rt, writeIdx++, jsiIntegrityThreadHash);
}
return jsiIntegrityThreadHashes; return jsiIntegrityThreadHashes;
} }
std::vector<std::unique_ptr<IntegrityStoreOperationBase>> std::vector<std::unique_ptr<IntegrityStoreOperationBase>>
IntegrityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations) IntegrityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const { const {
std::vector<std::unique_ptr<IntegrityStoreOperationBase>> integrityStoreOps; std::vector<std::unique_ptr<IntegrityStoreOperationBase>> integrityStoreOps;
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines