Page MenuHomePhabricator

[keyserver][lib] Split generateNotifUserInfoPromise into two
ClosedPublic

Authored by ashoat on Feb 11 2025, 12:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 4:27 AM
Unknown Object (File)
Sat, Mar 29, 12:10 PM
Unknown Object (File)
Wed, Mar 19, 3:18 AM
Unknown Object (File)
Mon, Mar 17, 8:46 PM
Unknown Object (File)
Sun, Mar 16, 12:26 PM
Unknown Object (File)
Tue, Mar 11, 4:11 PM
Unknown Object (File)
Tue, Mar 11, 3:50 PM
Unknown Object (File)
Thu, Mar 6, 2:53 PM
Subscribers
None

Details

Summary

This has two benefits:

  1. Avoids calling await getMessageNotifyType twice for every message.
  2. Exposes messageNotifyType to the callsite, which is necessary for a later diff.

Depends on D14334

Test Plan

Tested in combination with later diffs, to confirm that it's possible for some message types to not set a thread to unread

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable