Page MenuHomePhabricator
Differential D14341

[lib] Don't pass MessageData to getMessageNotifyType
ClosedPublic
Actions

Authored by ashoat on Feb 11 2025, 12:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 5:07 AM
Unknown Object (File)
Wed, Mar 26, 1:39 PM
Unknown Object (File)
Sat, Mar 22, 5:15 PM
Unknown Object (File)
Tue, Mar 11, 4:17 PM
Unknown Object (File)
Tue, Mar 11, 4:07 PM
Unknown Object (File)
Mar 2 2025, 5:58 AM
Unknown Object (File)
Feb 28 2025, 2:13 AM
Unknown Object (File)
Feb 28 2025, 2:03 AM
View All 28 Files
Subscribers
None

Details

Reviewers
tomek
angelika
Commits
rCOMM6616b63237f1: [lib] Don't pass MessageData to getMessageNotifyType
Summary

We want to do this because for DMs, we need to call this function on the recipient's side in order to determine whether to set a thread to unread. But the recipient does not have access to the MessageData.

Depends on D14340

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
push/
17 lines
shared/
messages/
1 line
1 line
1 line

Diff 47035

View Options

lib/push/utils.js

use backup_client::{ use backup_client::{
BackupClient, BackupData, BackupDescriptor, RequestedData, BackupClient, BackupData, BackupDescriptor, RequestedData,
}; };
use bytesize::ByteSize; use bytesize::ByteSize;
use comm_lib::{auth::UserIdentity, backup::LatestBackupIDResponse}; use comm_lib::{auth::UserIdentity, backup::LatestBackupIDResponse};
use commtest::identity::device::register_user_device;
use commtest::{ use commtest::{
service_addr, service_addr,
tools::{generate_stable_nbytes, obtain_number_of_threads, Error}, tools::{generate_stable_nbytes, obtain_number_of_threads, Error},
}; };
use grpc_clients::identity::DeviceType;
use tokio::{runtime::Runtime, task::JoinSet}; use tokio::{runtime::Runtime, task::JoinSet};
#[tokio::test] #[tokio::test]
async fn backup_performance_test() -> Result<(), Error> { async fn backup_performance_test() -> Result<(), Error> {
let backup_client = BackupClient::new(service_addr::BACKUP_SERVICE_HTTP)?; let backup_client = BackupClient::new(service_addr::BACKUP_SERVICE_HTTP)?;
let number_of_threads = obtain_number_of_threads(); let number_of_threads = obtain_number_of_threads();
Show All 16 Lines backup_data.push(BackupData {
ByteSize::mib(4).as_u64() as usize, ByteSize::mib(4).as_u64() as usize,
Some(i as u8), Some(i as u8),
), ),
attachments: vec![], attachments: vec![],
siwe_backup_msg: None, siwe_backup_msg: None,
}); });
} }
let device_info_1 = register_user_device(None, Some(DeviceType::Ios)).await;
let device_info_2 = register_user_device(None, Some(DeviceType::Ios)).await;
let user_identities = [ let user_identities = [
UserIdentity { UserIdentity {
user_id: "1".to_string(), user_id: device_info_1.user_id.clone(),
access_token: "dummy access token".to_string(), access_token: device_info_1.access_token,
device_id: "dummy device_id".to_string(), device_id: device_info_1.device_id,
}, },
UserIdentity { UserIdentity {
user_id: "2".to_string(), user_id: device_info_2.user_id.clone(),
access_token: "dummy access token".to_string(), access_token: device_info_2.access_token,
device_id: "dummy device_id".to_string(), device_id: device_info_2.device_id,
}, },
]; ];
tokio::task::spawn_blocking(move || { tokio::task::spawn_blocking(move || {
println!("Creating new backups"); println!("Creating new backups");
rt.block_on(async { rt.block_on(async {
let mut set = JoinSet::new(); let mut set = JoinSet::new();
for (i, item) in backup_data.iter().cloned().enumerate() { for (i, item) in backup_data.iter().cloned().enumerate() {
▲ Show 20 Lines • Show All 113 Lines • Show Last 20 Lines
View Options

lib/shared/messages/create-sub-thread-message-spec.js

use backup_client::{ use backup_client::{
BackupClient, BackupData, BackupDescriptor, RequestedData, BackupClient, BackupData, BackupDescriptor, RequestedData,
}; };
use bytesize::ByteSize; use bytesize::ByteSize;
use comm_lib::{auth::UserIdentity, backup::LatestBackupIDResponse}; use comm_lib::{auth::UserIdentity, backup::LatestBackupIDResponse};
use commtest::identity::device::register_user_device;
use commtest::{ use commtest::{
service_addr, service_addr,
tools::{generate_stable_nbytes, obtain_number_of_threads, Error}, tools::{generate_stable_nbytes, obtain_number_of_threads, Error},
}; };
use grpc_clients::identity::DeviceType;
use tokio::{runtime::Runtime, task::JoinSet}; use tokio::{runtime::Runtime, task::JoinSet};
#[tokio::test] #[tokio::test]
async fn backup_performance_test() -> Result<(), Error> { async fn backup_performance_test() -> Result<(), Error> {
let backup_client = BackupClient::new(service_addr::BACKUP_SERVICE_HTTP)?; let backup_client = BackupClient::new(service_addr::BACKUP_SERVICE_HTTP)?;
let number_of_threads = obtain_number_of_threads(); let number_of_threads = obtain_number_of_threads();
Show All 16 Lines backup_data.push(BackupData {
ByteSize::mib(4).as_u64() as usize, ByteSize::mib(4).as_u64() as usize,
Some(i as u8), Some(i as u8),
), ),
attachments: vec![], attachments: vec![],
siwe_backup_msg: None, siwe_backup_msg: None,
}); });
} }
let device_info_1 = register_user_device(None, Some(DeviceType::Ios)).await;
let device_info_2 = register_user_device(None, Some(DeviceType::Ios)).await;
let user_identities = [ let user_identities = [
UserIdentity { UserIdentity {
user_id: "1".to_string(), user_id: device_info_1.user_id.clone(),
access_token: "dummy access token".to_string(), access_token: device_info_1.access_token,
device_id: "dummy device_id".to_string(), device_id: device_info_1.device_id,
}, },
UserIdentity { UserIdentity {
user_id: "2".to_string(), user_id: device_info_2.user_id.clone(),
access_token: "dummy access token".to_string(), access_token: device_info_2.access_token,
device_id: "dummy device_id".to_string(), device_id: device_info_2.device_id,
}, },
]; ];
tokio::task::spawn_blocking(move || { tokio::task::spawn_blocking(move || {
println!("Creating new backups"); println!("Creating new backups");
rt.block_on(async { rt.block_on(async {
let mut set = JoinSet::new(); let mut set = JoinSet::new();
for (i, item) in backup_data.iter().cloned().enumerate() { for (i, item) in backup_data.iter().cloned().enumerate() {
▲ Show 20 Lines • Show All 113 Lines • Show Last 20 Lines
View Options

lib/shared/messages/message-spec.js

use backup_client::{ use backup_client::{
BackupClient, BackupData, BackupDescriptor, RequestedData, BackupClient, BackupData, BackupDescriptor, RequestedData,
}; };
use bytesize::ByteSize; use bytesize::ByteSize;
use comm_lib::{auth::UserIdentity, backup::LatestBackupIDResponse}; use comm_lib::{auth::UserIdentity, backup::LatestBackupIDResponse};
use commtest::identity::device::register_user_device;
use commtest::{ use commtest::{
service_addr, service_addr,
tools::{generate_stable_nbytes, obtain_number_of_threads, Error}, tools::{generate_stable_nbytes, obtain_number_of_threads, Error},
}; };
use grpc_clients::identity::DeviceType;
use tokio::{runtime::Runtime, task::JoinSet}; use tokio::{runtime::Runtime, task::JoinSet};
#[tokio::test] #[tokio::test]
async fn backup_performance_test() -> Result<(), Error> { async fn backup_performance_test() -> Result<(), Error> {
let backup_client = BackupClient::new(service_addr::BACKUP_SERVICE_HTTP)?; let backup_client = BackupClient::new(service_addr::BACKUP_SERVICE_HTTP)?;
let number_of_threads = obtain_number_of_threads(); let number_of_threads = obtain_number_of_threads();
Show All 16 Lines backup_data.push(BackupData {
ByteSize::mib(4).as_u64() as usize, ByteSize::mib(4).as_u64() as usize,
Some(i as u8), Some(i as u8),
), ),
attachments: vec![], attachments: vec![],
siwe_backup_msg: None, siwe_backup_msg: None,
}); });
} }
let device_info_1 = register_user_device(None, Some(DeviceType::Ios)).await;
let device_info_2 = register_user_device(None, Some(DeviceType::Ios)).await;
let user_identities = [ let user_identities = [
UserIdentity { UserIdentity {
user_id: "1".to_string(), user_id: device_info_1.user_id.clone(),
access_token: "dummy access token".to_string(), access_token: device_info_1.access_token,
device_id: "dummy device_id".to_string(), device_id: device_info_1.device_id,
}, },
UserIdentity { UserIdentity {
user_id: "2".to_string(), user_id: device_info_2.user_id.clone(),
access_token: "dummy access token".to_string(), access_token: device_info_2.access_token,
device_id: "dummy device_id".to_string(), device_id: device_info_2.device_id,
}, },
]; ];
tokio::task::spawn_blocking(move || { tokio::task::spawn_blocking(move || {
println!("Creating new backups"); println!("Creating new backups");
rt.block_on(async { rt.block_on(async {
let mut set = JoinSet::new(); let mut set = JoinSet::new();
for (i, item) in backup_data.iter().cloned().enumerate() { for (i, item) in backup_data.iter().cloned().enumerate() {
▲ Show 20 Lines • Show All 113 Lines • Show Last 20 Lines
View Options

lib/shared/messages/reaction-message-spec.js

use backup_client::{ use backup_client::{
BackupClient, BackupData, BackupDescriptor, RequestedData, BackupClient, BackupData, BackupDescriptor, RequestedData,
}; };
use bytesize::ByteSize; use bytesize::ByteSize;
use comm_lib::{auth::UserIdentity, backup::LatestBackupIDResponse}; use comm_lib::{auth::UserIdentity, backup::LatestBackupIDResponse};
use commtest::identity::device::register_user_device;
use commtest::{ use commtest::{
service_addr, service_addr,
tools::{generate_stable_nbytes, obtain_number_of_threads, Error}, tools::{generate_stable_nbytes, obtain_number_of_threads, Error},
}; };
use grpc_clients::identity::DeviceType;
use tokio::{runtime::Runtime, task::JoinSet}; use tokio::{runtime::Runtime, task::JoinSet};
#[tokio::test] #[tokio::test]
async fn backup_performance_test() -> Result<(), Error> { async fn backup_performance_test() -> Result<(), Error> {
let backup_client = BackupClient::new(service_addr::BACKUP_SERVICE_HTTP)?; let backup_client = BackupClient::new(service_addr::BACKUP_SERVICE_HTTP)?;
let number_of_threads = obtain_number_of_threads(); let number_of_threads = obtain_number_of_threads();
Show All 16 Lines backup_data.push(BackupData {
ByteSize::mib(4).as_u64() as usize, ByteSize::mib(4).as_u64() as usize,
Some(i as u8), Some(i as u8),
), ),
attachments: vec![], attachments: vec![],
siwe_backup_msg: None, siwe_backup_msg: None,
}); });
} }
let device_info_1 = register_user_device(None, Some(DeviceType::Ios)).await;
let device_info_2 = register_user_device(None, Some(DeviceType::Ios)).await;
let user_identities = [ let user_identities = [
UserIdentity { UserIdentity {
user_id: "1".to_string(), user_id: device_info_1.user_id.clone(),
access_token: "dummy access token".to_string(), access_token: device_info_1.access_token,
device_id: "dummy device_id".to_string(), device_id: device_info_1.device_id,
}, },
UserIdentity { UserIdentity {
user_id: "2".to_string(), user_id: device_info_2.user_id.clone(),
access_token: "dummy access token".to_string(), access_token: device_info_2.access_token,
device_id: "dummy device_id".to_string(), device_id: device_info_2.device_id,
}, },
]; ];
tokio::task::spawn_blocking(move || { tokio::task::spawn_blocking(move || {
println!("Creating new backups"); println!("Creating new backups");
rt.block_on(async { rt.block_on(async {
let mut set = JoinSet::new(); let mut set = JoinSet::new();
for (i, item) in backup_data.iter().cloned().enumerate() { for (i, item) in backup_data.iter().cloned().enumerate() {
▲ Show 20 Lines • Show All 113 Lines • Show Last 20 Lines