Page MenuHomePhabricator

[native] Introduce C++ MessageSpecs for membership robotext
ClosedPublic

Authored by ashoat on Feb 11 2025, 12:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 12:55 PM
Unknown Object (File)
Sat, Mar 22, 2:35 AM
Unknown Object (File)
Mon, Mar 10, 3:35 AM
Unknown Object (File)
Wed, Mar 5, 9:00 PM
Unknown Object (File)
Mar 2 2025, 8:21 PM
Unknown Object (File)
Feb 22 2025, 2:31 PM
Unknown Object (File)
Feb 22 2025, 12:43 PM
Unknown Object (File)
Feb 20 2025, 8:34 PM
Subscribers
None

Details

Summary

In the prior diff, we implement getMessageNotifyType in the JS membership robotext message specs. We don't actually set it up to ever send notifs, but simply specifying getMessageNotifyType leads to an Alert when the app starts because we don't have corresponding C++ message specs.

Since it was simple enough to do (even though they aren't used), I went ahead and implemented them.

Depends on D14345

Test Plan

Confirmed that the Alerts were no longer appearing on both iOS and Android

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable