Page MenuHomePhabricator
Differential D14346

[native] Introduce C++ MessageSpecs for membership robotext
ClosedPublic
Actions

Authored by ashoat on Feb 11 2025, 12:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 1:46 PM
Unknown Object (File)
Sun, Apr 20, 3:59 AM
Unknown Object (File)
Sat, Apr 19, 4:41 PM
Unknown Object (File)
Fri, Apr 18, 3:50 AM
Unknown Object (File)
Sun, Apr 13, 3:38 AM
Unknown Object (File)
Sun, Apr 6, 8:58 AM
Unknown Object (File)
Fri, Mar 28, 12:55 PM
Unknown Object (File)
Mar 22 2025, 2:35 AM
View All 35 Files
Subscribers
None

Details

Reviewers
tomek
angelika
Commits
rCOMM6f8f04efbb7f: [native] Introduce C++ MessageSpecs for membership robotext
Summary

In the prior diff, we implement getMessageNotifyType in the JS membership robotext message specs. We don't actually set it up to ever send notifs, but simply specifying getMessageNotifyType leads to an Alert when the app starts because we don't have corresponding C++ message specs.

Since it was simple enough to do (even though they aren't used), I went ahead and implemented them.

Depends on D14345

Test Plan

Confirmed that the Alerts were no longer appearing on both iOS and Android

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
PersistentStorageUtilities/
MessageOperationsUtilities/
19 lines
MessageSpecs/
13 lines
12 lines
12 lines
13 lines

Diff 46994

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs.h

Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines if [[ "$http_code" -ne 200 ]]; then
echo "Stopping primary and secondary nodes was successful. Continuing with migration." echo "Stopping primary and secondary nodes was successful. Continuing with migration."
break break
fi fi
total_elapsed_time=$(( total_elapsed_time + retry_interval )) total_elapsed_time=$(( total_elapsed_time + retry_interval ))
sleep $retry_interval sleep $retry_interval
done done
echo "Applying terraform changes" echo "Applying terraform changes"
terraform apply -auto-approve terraform apply -auto-approve
echo "Redisabling general lb traffic"
disable_general_lb_traffic
echo "Redeploying primary service in $cluster_name" echo "Redeploying primary service in $cluster_name"
aws ecs update-service --cluster "$cluster_name" --service "$primary_service_name" --force-new-deployment --desired-count 1 > /dev/null aws ecs update-service --cluster "$cluster_name" --service "$primary_service_name" --force-new-deployment --desired-count 1 > /dev/null
echo "Waiting for health check at $health_check_domain to return status 200 OK" echo "Waiting for health check at $health_check_domain to return status 200 OK"
check_health check_health
echo "Primary node successfully running. Re-enabling public access to load balancer"
enable_lb_traffic
echo "Setting desired count of secondary service to $num_desired_secondary_nodes". echo "Setting desired count of secondary service to $num_desired_secondary_nodes".
aws ecs update-service --cluster "$cluster_name" --service "$secondary_service_name" --desired-count "$num_desired_secondary_nodes" --force-new-deployment > /dev/null aws ecs update-service --cluster "$cluster_name" --service "$secondary_service_name" --desired-count "$num_desired_secondary_nodes" --force-new-deployment > /dev/null
echo "Successfully ran migration" echo "Successfully ran migration"
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/AddMembersMessageSpec.h

Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines if [[ "$http_code" -ne 200 ]]; then
echo "Stopping primary and secondary nodes was successful. Continuing with migration." echo "Stopping primary and secondary nodes was successful. Continuing with migration."
break break
fi fi
total_elapsed_time=$(( total_elapsed_time + retry_interval )) total_elapsed_time=$(( total_elapsed_time + retry_interval ))
sleep $retry_interval sleep $retry_interval
done done
echo "Applying terraform changes" echo "Applying terraform changes"
terraform apply -auto-approve terraform apply -auto-approve
echo "Redisabling general lb traffic"
disable_general_lb_traffic
echo "Redeploying primary service in $cluster_name" echo "Redeploying primary service in $cluster_name"
aws ecs update-service --cluster "$cluster_name" --service "$primary_service_name" --force-new-deployment --desired-count 1 > /dev/null aws ecs update-service --cluster "$cluster_name" --service "$primary_service_name" --force-new-deployment --desired-count 1 > /dev/null
echo "Waiting for health check at $health_check_domain to return status 200 OK" echo "Waiting for health check at $health_check_domain to return status 200 OK"
check_health check_health
echo "Primary node successfully running. Re-enabling public access to load balancer"
enable_lb_traffic
echo "Setting desired count of secondary service to $num_desired_secondary_nodes". echo "Setting desired count of secondary service to $num_desired_secondary_nodes".
aws ecs update-service --cluster "$cluster_name" --service "$secondary_service_name" --desired-count "$num_desired_secondary_nodes" --force-new-deployment > /dev/null aws ecs update-service --cluster "$cluster_name" --service "$secondary_service_name" --desired-count "$num_desired_secondary_nodes" --force-new-deployment > /dev/null
echo "Successfully ran migration" echo "Successfully ran migration"
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/JoinThreadMessageSpec.h

Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines if [[ "$http_code" -ne 200 ]]; then
echo "Stopping primary and secondary nodes was successful. Continuing with migration." echo "Stopping primary and secondary nodes was successful. Continuing with migration."
break break
fi fi
total_elapsed_time=$(( total_elapsed_time + retry_interval )) total_elapsed_time=$(( total_elapsed_time + retry_interval ))
sleep $retry_interval sleep $retry_interval
done done
echo "Applying terraform changes" echo "Applying terraform changes"
terraform apply -auto-approve terraform apply -auto-approve
echo "Redisabling general lb traffic"
disable_general_lb_traffic
echo "Redeploying primary service in $cluster_name" echo "Redeploying primary service in $cluster_name"
aws ecs update-service --cluster "$cluster_name" --service "$primary_service_name" --force-new-deployment --desired-count 1 > /dev/null aws ecs update-service --cluster "$cluster_name" --service "$primary_service_name" --force-new-deployment --desired-count 1 > /dev/null
echo "Waiting for health check at $health_check_domain to return status 200 OK" echo "Waiting for health check at $health_check_domain to return status 200 OK"
check_health check_health
echo "Primary node successfully running. Re-enabling public access to load balancer"
enable_lb_traffic
echo "Setting desired count of secondary service to $num_desired_secondary_nodes". echo "Setting desired count of secondary service to $num_desired_secondary_nodes".
aws ecs update-service --cluster "$cluster_name" --service "$secondary_service_name" --desired-count "$num_desired_secondary_nodes" --force-new-deployment > /dev/null aws ecs update-service --cluster "$cluster_name" --service "$secondary_service_name" --desired-count "$num_desired_secondary_nodes" --force-new-deployment > /dev/null
echo "Successfully ran migration" echo "Successfully ran migration"
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/LeaveThreadMessageSpec.h

Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines if [[ "$http_code" -ne 200 ]]; then
echo "Stopping primary and secondary nodes was successful. Continuing with migration." echo "Stopping primary and secondary nodes was successful. Continuing with migration."
break break
fi fi
total_elapsed_time=$(( total_elapsed_time + retry_interval )) total_elapsed_time=$(( total_elapsed_time + retry_interval ))
sleep $retry_interval sleep $retry_interval
done done
echo "Applying terraform changes" echo "Applying terraform changes"
terraform apply -auto-approve terraform apply -auto-approve
echo "Redisabling general lb traffic"
disable_general_lb_traffic
echo "Redeploying primary service in $cluster_name" echo "Redeploying primary service in $cluster_name"
aws ecs update-service --cluster "$cluster_name" --service "$primary_service_name" --force-new-deployment --desired-count 1 > /dev/null aws ecs update-service --cluster "$cluster_name" --service "$primary_service_name" --force-new-deployment --desired-count 1 > /dev/null
echo "Waiting for health check at $health_check_domain to return status 200 OK" echo "Waiting for health check at $health_check_domain to return status 200 OK"
check_health check_health
echo "Primary node successfully running. Re-enabling public access to load balancer"
enable_lb_traffic
echo "Setting desired count of secondary service to $num_desired_secondary_nodes". echo "Setting desired count of secondary service to $num_desired_secondary_nodes".
aws ecs update-service --cluster "$cluster_name" --service "$secondary_service_name" --desired-count "$num_desired_secondary_nodes" --force-new-deployment > /dev/null aws ecs update-service --cluster "$cluster_name" --service "$secondary_service_name" --desired-count "$num_desired_secondary_nodes" --force-new-deployment > /dev/null
echo "Successfully ran migration" echo "Successfully ran migration"
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/RemoveMembersMessageSpec.h

Loading...