Page MenuHomePhabricator
Differential D14328

[keyserver] Introduce new last_message_for_unread_check column
ClosedPublic
Actions

Authored by ashoat on Feb 10 2025, 11:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 12:12 AM
Unknown Object (File)
Fri, Mar 28, 6:21 PM
Unknown Object (File)
Sat, Mar 22, 8:54 AM
Unknown Object (File)
Thu, Mar 20, 2:56 PM
Unknown Object (File)
Mon, Mar 17, 9:15 PM
Unknown Object (File)
Fri, Mar 14, 5:25 AM
Unknown Object (File)
Fri, Mar 14, 5:21 AM
Unknown Object (File)
Fri, Mar 14, 4:02 AM
View All 46 Files
Subscribers
None

Details

Reviewers
tomek
angelika
Commits
rCOMM13de3a20759a: [keyserver] Introduce new last_message_for_unread_check column
Summary

Context here. This is "solution 2" proposed there.

Test Plan

Tested in combination with later diffs, to confirm that it's possible for some message types to not set a thread to unread

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
database/
16 lines
1 line

Diff 47024

View Options

keyserver/src/database/migration-config.js

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines size_t decryptedSize = ::olm_decrypt(
decryptedMessage.data(), decryptedMessage.data(),
decryptedMessage.size()); decryptedMessage.size());
if (decryptedSize == -1) { if (decryptedSize == -1) {
throw std::runtime_error{ throw std::runtime_error{
"error decrypt => " + std::string{::olm_session_last_error(session)} + "error decrypt => " + std::string{::olm_session_last_error(session)} +
". Hash: " + ". Hash: " +
std::string{messageHashBuffer.begin(), messageHashBuffer.end()}}; std::string{messageHashBuffer.begin(), messageHashBuffer.end()}};
} }
return std::string{(char *)decryptedMessage.data(), decryptedSize}; return std::string{decryptedMessage.begin(), decryptedMessage.end()};
} }
std::string Session::decryptSequential(EncryptedData &encryptedData) { std::string Session::decryptSequential(EncryptedData &encryptedData) {
OlmSession *session = this->getOlmSession(); OlmSession *session = this->getOlmSession();
OlmBuffer utilityBuffer(::olm_utility_size()); OlmBuffer utilityBuffer(::olm_utility_size());
OlmUtility *olmUtility = ::olm_utility(utilityBuffer.data()); OlmUtility *olmUtility = ::olm_utility(utilityBuffer.data());
Show All 28 Lines size_t decryptedSize = ::olm_decrypt_sequential(
decryptedMessage.data(), decryptedMessage.data(),
decryptedMessage.size()); decryptedMessage.size());
if (decryptedSize == -1) { if (decryptedSize == -1) {
throw std::runtime_error{ throw std::runtime_error{
"error decrypt_sequential => " + "error decrypt_sequential => " +
std::string{::olm_session_last_error(session)} + ". Hash: " + std::string{::olm_session_last_error(session)} + ". Hash: " +
std::string{messageHashBuffer.begin(), messageHashBuffer.end()}}; std::string{messageHashBuffer.begin(), messageHashBuffer.end()}};
} }
return std::string{(char *)decryptedMessage.data(), decryptedSize}; return std::string{decryptedMessage.begin(), decryptedMessage.end()};
} }
int Session::getVersion() { int Session::getVersion() {
return this->version; return this->version;
} }
void Session::setVersion(int newVersion) { void Session::setVersion(int newVersion) {
this->version = newVersion; this->version = newVersion;
} }
} // namespace crypto } // namespace crypto
} // namespace comm } // namespace comm
View Options

keyserver/src/database/setup-db.js

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines size_t decryptedSize = ::olm_decrypt(
decryptedMessage.data(), decryptedMessage.data(),
decryptedMessage.size()); decryptedMessage.size());
if (decryptedSize == -1) { if (decryptedSize == -1) {
throw std::runtime_error{ throw std::runtime_error{
"error decrypt => " + std::string{::olm_session_last_error(session)} + "error decrypt => " + std::string{::olm_session_last_error(session)} +
". Hash: " + ". Hash: " +
std::string{messageHashBuffer.begin(), messageHashBuffer.end()}}; std::string{messageHashBuffer.begin(), messageHashBuffer.end()}};
} }
return std::string{(char *)decryptedMessage.data(), decryptedSize}; return std::string{decryptedMessage.begin(), decryptedMessage.end()};
} }
std::string Session::decryptSequential(EncryptedData &encryptedData) { std::string Session::decryptSequential(EncryptedData &encryptedData) {
OlmSession *session = this->getOlmSession(); OlmSession *session = this->getOlmSession();
OlmBuffer utilityBuffer(::olm_utility_size()); OlmBuffer utilityBuffer(::olm_utility_size());
OlmUtility *olmUtility = ::olm_utility(utilityBuffer.data()); OlmUtility *olmUtility = ::olm_utility(utilityBuffer.data());
Show All 28 Lines size_t decryptedSize = ::olm_decrypt_sequential(
decryptedMessage.data(), decryptedMessage.data(),
decryptedMessage.size()); decryptedMessage.size());
if (decryptedSize == -1) { if (decryptedSize == -1) {
throw std::runtime_error{ throw std::runtime_error{
"error decrypt_sequential => " + "error decrypt_sequential => " +
std::string{::olm_session_last_error(session)} + ". Hash: " + std::string{::olm_session_last_error(session)} + ". Hash: " +
std::string{messageHashBuffer.begin(), messageHashBuffer.end()}}; std::string{messageHashBuffer.begin(), messageHashBuffer.end()}};
} }
return std::string{(char *)decryptedMessage.data(), decryptedSize}; return std::string{decryptedMessage.begin(), decryptedMessage.end()};
} }
int Session::getVersion() { int Session::getVersion() {
return this->version; return this->version;
} }
void Session::setVersion(int newVersion) { void Session::setVersion(int newVersion) {
this->version = newVersion; this->version = newVersion;
} }
} // namespace crypto } // namespace crypto
} // namespace comm } // namespace comm