Page MenuHomePhabricator
Differential D14340

[lib] Use notificationCollapseKey to dedup sidebarCreation notifs in multimediaMessageSpec
ClosedPublic
Actions

Authored by ashoat on Feb 11 2025, 12:23 AM.
Tags
None
Referenced Files
F6047017: D14340.id46988.diff
Sun, Apr 20, 5:10 AM
F6027870: D14340.id47036.diff
Sat, Apr 19, 9:04 PM
Unknown Object (File)
Fri, Apr 18, 7:54 PM
Unknown Object (File)
Thu, Apr 17, 10:50 PM
Unknown Object (File)
Mar 15 2025, 10:52 PM
Unknown Object (File)
Mar 11 2025, 4:12 PM
Unknown Object (File)
Mar 11 2025, 3:48 PM
Unknown Object (File)
Mar 2 2025, 7:31 AM
View All 29 Files
Subscribers
None

Details

Reviewers
tomek
angelika
Commits
rCOMM965ac1fc0b1b: [lib] Use notificationCollapseKey to dedup sidebarCreation notifs in…
Summary

In the next diff, we'll remove the MessageData parameter from getMessageNotifyType. We want to do this because for DMs, we need to call this function on the recipient's side in order to determine whether to set a thread to unread. But the recipient does not have access to the MessageData.

The only place where we need the MessageData in getMessageNotifyType is multimediaMessageSpec. This usage was introduced in D6798 to prevent double-notifs on sidebar creation in both textMessageSpec and multimediaMessageSpec. However, in D6938 we introduced an alternative approach to prevent double-notifs in textMessageSpec; this diff uses the same approach for multimediaMessageSpec.

Depends on D14339

Test Plan
  • Tested creating a sidebar from a non-viewer message with a multimedia message, and confirmed it only sent 1 notif to the other user in the sidebar (the author of the sidebar source message)
  • Tested sending a normal multimedia and confirmed that it still sent a notif

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
26 lines

Diff 47036

View Options

lib/shared/messages/multimedia-message-spec.js

Show All 16 LinesIntegrityStore::IntegrityStore(
std::shared_ptr<facebook::react::CallInvoker> jsInvoker) std::shared_ptr<facebook::react::CallInvoker> jsInvoker)
: BaseDataStore(jsInvoker) { : BaseDataStore(jsInvoker) {
} }
jsi::Array IntegrityStore::parseDBDataStore( jsi::Array IntegrityStore::parseDBDataStore(
jsi::Runtime &rt, jsi::Runtime &rt,
std::shared_ptr<std::vector<IntegrityThreadHash>> std::shared_ptr<std::vector<IntegrityThreadHash>>
integrityThreadHashesVectorPtr) const { integrityThreadHashesVectorPtr) const {
jsi::Array jsiIntegrityThreadHashes = jsi::Array(rt, 0); size_t numIntegrityThreadHashes = integrityThreadHashesVectorPtr->size();
jsi::Array jsiIntegrityThreadHashes =
jsi::Array(rt, numIntegrityThreadHashes);
size_t writeIdx = 0;
for (const IntegrityThreadHash &integrityThreadHash :
*integrityThreadHashesVectorPtr) {
jsi::Object jsiIntegrityThreadHash = jsi::Object(rt);
jsiIntegrityThreadHash.setProperty(rt, "id", integrityThreadHash.id);
jsiIntegrityThreadHash.setProperty(
rt, "threadHash", integrityThreadHash.thread_hash);
jsiIntegrityThreadHashes.setValueAtIndex(
rt, writeIdx++, jsiIntegrityThreadHash);
}
return jsiIntegrityThreadHashes; return jsiIntegrityThreadHashes;
} }
std::vector<std::unique_ptr<IntegrityStoreOperationBase>> std::vector<std::unique_ptr<IntegrityStoreOperationBase>>
IntegrityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations) IntegrityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const { const {
std::vector<std::unique_ptr<IntegrityStoreOperationBase>> integrityStoreOps; std::vector<std::unique_ptr<IntegrityStoreOperationBase>> integrityStoreOps;
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines