Page MenuHomePhabricator
Differential D13918

[lib] Reactions only bump thread timestamps when reacting to viewer
AcceptedPublic
Actions

Authored by ashoat on Tue, Nov 12, 12:46 PM.
Tags
None
Referenced Files
F3329565: D13918.id45780.diff
Wed, Nov 20, 5:24 PM
F3328017: D13918.diff
Wed, Nov 20, 1:05 PM
F3327784: D13918.id45773.diff
Wed, Nov 20, 12:27 PM
F3327058: D13918.id45772.diff
Wed, Nov 20, 8:15 AM
Unknown Object (File)
Tue, Nov 19, 8:40 PM
Unknown Object (File)
Tue, Nov 19, 8:18 PM
Unknown Object (File)
Tue, Nov 19, 6:05 PM
Unknown Object (File)
Tue, Nov 19, 12:01 PM
View All 28 Files
Subscribers
None

Details

Reviewers
tomek
Summary

This addresses ENG-9558 for reaction robotext messages. The implementation is broadly similar to D13828.

Depends on D13916

Test Plan

I logged in as two users on web, and with the second user, tested reacting to the first user's messages and other messages. Confirmed that the timestamp was bumped for the first user only when reacting to their messages. I also tested this with a sleep to confirm that the timestamps would only be bumped after the promise resolved

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Tue, Nov 12, 12:46 PM
ashoat added a child revision: D13919: [lib] Don't bump thin thread timestamp for membership robotext.
ashoat edited the test plan for this revision. (Show Details)Tue, Nov 12, 12:48 PM
ashoat mentioned this in D13916: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.
ashoat mentioned this in D13915: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.
ashoat updated this revision to Diff 45771.Tue, Nov 12, 12:57 PM

Rebase

Harbormaster failed remote builds in B32629: Diff 45765!Tue, Nov 12, 1:15 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Nov 12, 1:27 PM
Harbormaster failed remote builds in B32635: Diff 45771!
ashoat updated this revision to Diff 45778.Tue, Nov 12, 1:58 PM

Rebase

Harbormaster completed remote builds in B32640: Diff 45778.Tue, Nov 12, 3:24 PM
ashoat requested review of this revision.Tue, Nov 12, 3:24 PM
tomek accepted this revision.Wed, Nov 13, 4:53 AM
This revision is now accepted and ready to land.Wed, Nov 13, 4:53 AM
ashoat mentioned this in rCOMMed9e9cf2c268: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.Wed, Nov 13, 11:20 AM
ashoat mentioned this in rCOMM4d3afd3231b5: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
15 lines

Diff 45778

View Options

lib/shared/messages/reaction-message-spec.js

Loading...