Paths

Table of Contentst

-
lib/shared/messages/
-
shared/
-
messages/
-
reaction-message-spec.js

Differential D13918

[lib] Reactions only bump thread timestamps when reacting to viewer
ClosedPublic
Actions

Authored by ashoat on Nov 12 2024, 12:46 PM.

Tags

None

Referenced Files

	F5729391: D13918.id46367.diff
	Mon, Apr 14, 9:56 AM

	Unknown Object (File)
	Mon, Apr 7, 6:42 PM

	Unknown Object (File)
	Tue, Mar 18, 12:45 PM

	Unknown Object (File)
	Mar 15 2025, 7:31 AM

	Unknown Object (File)
	Mar 14 2025, 7:37 AM

	Unknown Object (File)
	Mar 14 2025, 5:06 AM

	Unknown Object (File)
	Mar 14 2025, 4:25 AM

	Unknown Object (File)
	Mar 14 2025, 4:16 AM

Subscribers

None

Details

Reviewers

Commits

rCOMM880d244d0286: [lib] Reactions only bump thread timestamps when reacting to viewer

Summary

This addresses ENG-9558 for reaction robotext messages. The implementation is broadly similar to D13828.

Depends on D13829

Test Plan

I logged in as two users on web, and with the second user, tested reacting to the first user's messages and other messages. Confirmed that the timestamp was bumped for the first user only when reacting to their messages. I also tested this with a sleep to confirm that the timestamps would only be bumped after the promise resolved

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 12 2024, 12:46 PM

ashoat added a child revision: D13919: [lib] Don't bump thin thread timestamp for membership robotext.

ashoat edited the test plan for this revision. (Show Details)Nov 12 2024, 12:48 PM

ashoat mentioned this in D13916: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.

ashoat mentioned this in D13915: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.

Rebase

Harbormaster failed remote builds in B32629: Diff 45765!Nov 12 2024, 1:15 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 12 2024, 1:27 PM

Harbormaster failed remote builds in B32635: Diff 45771!

Rebase

Harbormaster completed remote builds in B32640: Diff 45778.Nov 12 2024, 3:24 PM

ashoat requested review of this revision.Nov 12 2024, 3:24 PM

tomek accepted this revision.Nov 13 2024, 4:53 AM

This revision is now accepted and ready to land.Nov 13 2024, 4:53 AM

ashoat mentioned this in rCOMMed9e9cf2c268: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.Nov 13 2024, 11:20 AM

ashoat mentioned this in rCOMM4d3afd3231b5: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.

ashoat edited parent revisions, added: D13984: [lib] Fix incorrect timestamps for sidebars; removed: D13916: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.Dec 10 2024, 8:25 AM

ashoat edited the summary of this revision. (Show Details)

ashoat edited the summary of this revision. (Show Details)Dec 11 2024, 3:54 PM

ashoat added a parent revision: D13829: [lib] Hide membership robotext from MessagePreview in thin threads.

ashoat removed a parent revision: D13984: [lib] Fix incorrect timestamps for sidebars.

Rebase

Rebase

Harbormaster completed remote builds in B33048: Diff 46366.Dec 11 2024, 5:25 PM

Harbormaster completed remote builds in B33049: Diff 46367.Dec 11 2024, 5:33 PM

Ashoat Tevosyan <ashoat@gmail.com> mentioned this in rCOMM85d0b02b1949: [lib][native][web] Update useSidebarInfos to include lastUpdatedAtLeastTime.Dec 13 2024, 6:13 AM

Ashoat Tevosyan <ashoat@gmail.com> mentioned this in rCOMM0943dead4c72: [lib][web] Await lastUpdatedTime and update ChatThreadItems if different.

Rebase

Harbormaster failed remote builds in B33386: Diff 46905!Feb 4 2025, 8:35 PM

Rebase

Harbormaster completed remote builds in B33401: Diff 46928.Feb 5 2025, 6:36 PM

Closed by commit rCOMM880d244d0286: [lib] Reactions only bump thread timestamps when reacting to viewer (authored by ashoat). · Explain WhyFeb 12 2025, 5:59 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM880d244d0286: [lib] Reactions only bump thread timestamps when reacting to viewer.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

reaction-message-spec.js

17 lines

Diff 47041

lib/shared/messages/reaction-message-spec.js

	Show First 20 Lines • Show All 827 Lines • ▼ Show 20 Lines		[
	() =>			() =>
	dbQuery(SQL`			dbQuery(SQL`
	ALTER TABLE invite_links			ALTER TABLE invite_links
	ADD COLUMN IF NOT EXISTS thread bigint(20) DEFAULT NULL,			ADD COLUMN IF NOT EXISTS thread bigint(20) DEFAULT NULL,
	ADD COLUMN IF NOT EXISTS thread_role bigint(20) DEFAULT NULL,			ADD COLUMN IF NOT EXISTS thread_role bigint(20) DEFAULT NULL,
	ADD INDEX IF NOT EXISTS community_thread (community, thread);			ADD INDEX IF NOT EXISTS community_thread (community, thread);
	`),			`),
	],			],
				[66, updateRolesAndPermissionsForAllThreads],
	]);			]);
	const newDatabaseVersion: number = Math.max(...migrations.keys());			const newDatabaseVersion: number = Math.max(...migrations.keys());

	async function writeJSONToFile(data: any, filePath: string): Promise<void> {			async function writeJSONToFile(data: any, filePath: string): Promise<void> {
	console.warn(`updating ${filePath} to ${JSON.stringify(data)}`);			console.warn(`updating ${filePath} to ${JSON.stringify(data)}`);
	const fileHandle = await fs.promises.open(filePath, 'w');			const fileHandle = await fs.promises.open(filePath, 'w');
	await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8');			await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8');
	await fileHandle.close();			await fileHandle.close();
	▲ Show 20 Lines • Show All 130 Lines • Show Last 20 Lines