Page MenuHomePhabricator
Differential D14342

[lib] Add messagesNotifyTypes to ProcessDMOpsPayload
ClosedPublic
Actions

Authored by ashoat on Feb 11 2025, 12:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 8:19 AM
Unknown Object (File)
Mon, Mar 17, 9:16 PM
Unknown Object (File)
Tue, Mar 11, 4:15 PM
Unknown Object (File)
Tue, Mar 11, 3:55 PM
Unknown Object (File)
Tue, Mar 11, 7:01 AM
Unknown Object (File)
Mar 3 2025, 2:12 PM
Unknown Object (File)
Mar 1 2025, 4:21 AM
Unknown Object (File)
Feb 28 2025, 2:13 AM
View All 37 Files
Subscribers
None

Details

Reviewers
tomek
angelika
Commits
rCOMM114ba23ad0f2: [lib] Add messagesNotifyTypes to ProcessDMOpsPayload
Summary

We want to get access to this data in reducers. Since it requires an await, we need to determine it prior to the dispatch.

Depends on D14341

Test Plan

Tested in combination with later diffs, to confirm that it's possible for some message types to not set a thread to unread

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
126 lines
types/
2 lines

Diff 46990

View Options

lib/shared/dm-ops/process-dm-ops.js

use anyhow::Result; use anyhow::Result;
use comm_lib::{auth::AuthService, blob::client::BlobServiceClient}; use comm_lib::{auth::AuthService, blob::client::BlobServiceClient};
use tracing::Level; use tracing::Level;
use tracing_subscriber::EnvFilter; use tracing_subscriber::EnvFilter;
pub mod config; pub mod config;
pub mod constants; pub mod constants;
pub mod database; pub mod database;
pub mod error; pub mod error;
pub mod http; pub mod http;
pub mod identity;
// re-export this to be available as crate::CONFIG // re-export this to be available as crate::CONFIG
pub use config::CONFIG; pub use config::CONFIG;
fn configure_logging() -> Result<()> { fn configure_logging() -> Result<()> {
let filter = EnvFilter::builder() let filter = EnvFilter::builder()
.with_default_directive(Level::INFO.into()) .with_default_directive(Level::INFO.into())
.with_env_var(constants::LOG_LEVEL_ENV_VAR) .with_env_var(constants::LOG_LEVEL_ENV_VAR)
Show All 21 Lines
View Options

lib/types/dm-ops.js

use anyhow::Result; use anyhow::Result;
use comm_lib::{auth::AuthService, blob::client::BlobServiceClient}; use comm_lib::{auth::AuthService, blob::client::BlobServiceClient};
use tracing::Level; use tracing::Level;
use tracing_subscriber::EnvFilter; use tracing_subscriber::EnvFilter;
pub mod config; pub mod config;
pub mod constants; pub mod constants;
pub mod database; pub mod database;
pub mod error; pub mod error;
pub mod http; pub mod http;
pub mod identity;
// re-export this to be available as crate::CONFIG // re-export this to be available as crate::CONFIG
pub use config::CONFIG; pub use config::CONFIG;
fn configure_logging() -> Result<()> { fn configure_logging() -> Result<()> {
let filter = EnvFilter::builder() let filter = EnvFilter::builder()
.with_default_directive(Level::INFO.into()) .with_default_directive(Level::INFO.into())
.with_env_var(constants::LOG_LEVEL_ENV_VAR) .with_env_var(constants::LOG_LEVEL_ENV_VAR)
Show All 21 Lines