Page MenuHomePhabricator

[native] Factor out listLoadingIndicatorHeight
ClosedPublic

Authored by ashoat on Dec 11 2024, 3:51 PM.
Tags
None
Referenced Files
F6081092: D14142.id46361.diff
Sun, Apr 20, 8:33 PM
F6055973: D14142.diff
Sun, Apr 20, 7:09 AM
Unknown Object (File)
Wed, Apr 9, 1:42 PM
Unknown Object (File)
Mar 11 2025, 4:11 PM
Unknown Object (File)
Mar 11 2025, 10:08 AM
Unknown Object (File)
Mar 6 2025, 2:58 AM
Unknown Object (File)
Mar 2 2025, 7:11 AM
Unknown Object (File)
Feb 28 2025, 1:54 AM
Subscribers
None

Details

Summary

This is used in multiple places already. In the next diff I introduce a third usage, so I figured it makes sense to factor out.

I put this in a separate file from the component (ListLoadingIndicator) because exporting a constant alongside a React component can break hot reloading (some context here and here).

Depends on D14141

Test Plan

I tested this task by playing around with the ChatThreadList on mobile while using a stopwatch to measure how long various operations took. I tested the updated code 3 times against both the most recent Testflight build as well as master. I found that performance was approximately the same as before. I tested scrolling down, selecting threads that were read, selecting threads that were unread, and search.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable