HomePhabricator
Diffusion Comm 058864d257ed

[native] Factor out listLoadingIndicatorHeight

Description

[native] Factor out listLoadingIndicatorHeight

Summary:
This is used in multiple places already. In the next diff I introduce a third usage, so I figured it makes sense to factor out.

I put this in a separate file from the component (ListLoadingIndicator) because exporting a constant alongside a React component can break hot reloading (some context here and here).

Depends on D14141

Test Plan: I tested this task by playing around with the ChatThreadList on mobile while using a stopwatch to measure how long various operations took. I tested the updated code 3 times against both the most recent Testflight build as well as master. I found that performance was approximately the same as before. I tested scrolling down, selecting threads that were read, selecting threads that were unread, and search.

Reviewers: tomek, angelika

Reviewed By: tomek

Differential Revision: https://phab.comm.dev/D14142

Details

Provenance
ashoatAuthored on Wed, Dec 11, 11:15 AM
Reviewer
tomek
Differential Revision
D14142: [native] Factor out listLoadingIndicatorHeight
Parents
rCOMM3dba5dbadd19: [lib][native] Update native to use ChatThreadItemLoaderCache
Branches
Unknown
Tags
Unknown