Page MenuHomePhabricator

[native] Factor out listLoadingIndicatorHeight
ClosedPublic

Authored by ashoat on Wed, Dec 11, 3:51 PM.
Tags
None
Referenced Files
F3513950: D14142.diff
Sun, Dec 22, 2:43 AM
F3509949: D14142.id46363.diff
Sat, Dec 21, 9:43 AM
F3509893: D14142.id46444.diff
Sat, Dec 21, 9:10 AM
F3509296: D14142.id46361.diff
Sat, Dec 21, 3:13 AM
Unknown Object (File)
Fri, Dec 20, 2:36 AM
Unknown Object (File)
Thu, Dec 19, 7:39 PM
Unknown Object (File)
Thu, Dec 19, 10:16 AM
Unknown Object (File)
Wed, Dec 18, 1:21 PM
Subscribers
None

Details

Summary

This is used in multiple places already. In the next diff I introduce a third usage, so I figured it makes sense to factor out.

I put this in a separate file from the component (ListLoadingIndicator) because exporting a constant alongside a React component can break hot reloading (some context here and here).

Depends on D14141

Test Plan

I tested this task by playing around with the ChatThreadList on mobile while using a stopwatch to measure how long various operations took. I tested the updated code 3 times against both the most recent Testflight build as well as master. I found that performance was approximately the same as before. I tested scrolling down, selecting threads that were read, selecting threads that were unread, and search.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable