Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3509893
D14142.id46444.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D14142.id46444.diff
View Options
diff --git a/native/calendar/calendar-screen.react.js b/native/calendar/calendar-screen.react.js
--- a/native/calendar/calendar-screen.react.js
+++ b/native/calendar/calendar-screen.react.js
@@ -60,6 +60,7 @@
} from './entry.react.js';
import SectionFooter from './section-footer.react.js';
import ContentLoading from '../components/content-loading.react.js';
+import { listLoadingIndicatorHeight } from '../components/list-loading-indicator-utils.js';
import ListLoadingIndicator from '../components/list-loading-indicator.react.js';
import NodeHeightMeasurer from '../components/node-height-measurer.react.js';
import {
@@ -585,7 +586,7 @@
// eslint-disable-next-line consistent-return
static itemHeight = (item: CalendarItemWithHeight): number => {
if (item.itemType === 'loader') {
- return 56;
+ return listLoadingIndicatorHeight;
} else if (item.itemType === 'header') {
return 31;
} else if (item.itemType === 'entryInfo') {
diff --git a/native/chat/utils.js b/native/chat/utils.js
--- a/native/chat/utils.js
+++ b/native/chat/utils.js
@@ -20,6 +20,7 @@
import { getUnresolvedSidebarThreadInfo } from './sidebar-navigation.js';
import textMessageSendFailed from './text-message-send-failed.js';
import { timestampHeight } from './timestamp.react.js';
+import { listLoadingIndicatorHeight } from '../components/list-loading-indicator-utils.js';
import { KeyboardContext } from '../keyboard/keyboard-state.js';
import { OverlayContext } from '../navigation/overlay-context.js';
import {
@@ -86,7 +87,7 @@
function chatMessageItemHeight(item: ChatMessageItemWithHeight): number {
if (item.itemType === 'loader') {
- return 56;
+ return listLoadingIndicatorHeight;
}
return messageItemHeight(item);
}
diff --git a/native/components/list-loading-indicator-utils.js b/native/components/list-loading-indicator-utils.js
new file mode 100644
--- /dev/null
+++ b/native/components/list-loading-indicator-utils.js
@@ -0,0 +1,3 @@
+// @flow
+
+export const listLoadingIndicatorHeight = 56;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Dec 22, 9:10 AM (6 h, 43 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2690268
Default Alt Text
D14142.id46444.diff (2 KB)
Attached To
Mode
D14142: [native] Factor out listLoadingIndicatorHeight
Attached
Detach File
Event Timeline
Log In to Comment