Page MenuHomePhabricator
Files F3513950

D14142.diff
No OneTemporary
Actions

D14142.diff
View Options

diff --git a/native/calendar/calendar-screen.react.js b/native/calendar/calendar-screen.react.js
--- a/native/calendar/calendar-screen.react.js
+++ b/native/calendar/calendar-screen.react.js
@@ -60,6 +60,7 @@
} from './entry.react.js';
import SectionFooter from './section-footer.react.js';
import ContentLoading from '../components/content-loading.react.js';
+import { listLoadingIndicatorHeight } from '../components/list-loading-indicator-utils.js';
import ListLoadingIndicator from '../components/list-loading-indicator.react.js';
import NodeHeightMeasurer from '../components/node-height-measurer.react.js';
import {
@@ -585,7 +586,7 @@
// eslint-disable-next-line consistent-return
static itemHeight = (item: CalendarItemWithHeight): number => {
if (item.itemType === 'loader') {
- return 56;
+ return listLoadingIndicatorHeight;
} else if (item.itemType === 'header') {
return 31;
} else if (item.itemType === 'entryInfo') {
diff --git a/native/chat/utils.js b/native/chat/utils.js
--- a/native/chat/utils.js
+++ b/native/chat/utils.js
@@ -20,6 +20,7 @@
import { getUnresolvedSidebarThreadInfo } from './sidebar-navigation.js';
import textMessageSendFailed from './text-message-send-failed.js';
import { timestampHeight } from './timestamp.react.js';
+import { listLoadingIndicatorHeight } from '../components/list-loading-indicator-utils.js';
import { KeyboardContext } from '../keyboard/keyboard-state.js';
import { OverlayContext } from '../navigation/overlay-context.js';
import {
@@ -86,7 +87,7 @@
function chatMessageItemHeight(item: ChatMessageItemWithHeight): number {
if (item.itemType === 'loader') {
- return 56;
+ return listLoadingIndicatorHeight;
}
return messageItemHeight(item);
}
diff --git a/native/components/list-loading-indicator-utils.js b/native/components/list-loading-indicator-utils.js
new file mode 100644
--- /dev/null
+++ b/native/components/list-loading-indicator-utils.js
@@ -0,0 +1,3 @@
+// @flow
+
+export const listLoadingIndicatorHeight = 56;

File Metadata

Mime Type
text/plain
Expires
Mon, Dec 23, 2:43 AM (18 h, 30 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2690268
Default Alt Text
D14142.diff (2 KB)

Event Timeline