[lib] Extract initialChatThreadItem
ClosedPublic
Actions

Authored by ashoat on Dec 11 2024, 3:46 PM.

Details

Reviewers

tomek
angelika

Commits

rCOMM77ed3c708135: [lib] Extract initialChatThreadItem

Summary

This diff extracts some code for determining the initial ChatThreadItem to display while the Promise returned by getFinalChatThreadItem is resolving.

The code is currently in useChatThreadItems, which is the only current caller of useCreateChatThreadItem. In a later diff, we'll be introducing another caller of useCreateChatThreadItem that also needs this.

To share the code, this diff moves the logic into useCreateChatThreadItem, which now returns it as part of CreatedChatThreadItem.

Depends on D14137

Test Plan

I tested this task by playing around with the ChatThreadList on mobile while using a stopwatch to measure how long various operations took. I tested the updated code 3 times against both the most recent Testflight build as well as master. I found that performance was approximately the same as before. I tested scrolling down, selecting threads that were read, selecting threads that were unread, and search.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 11 2024, 3:46 PM

ashoat added a child revision: D14139: [lib] Rename useCreateChatThreadItem to useGetChatThreadItemLoader.

Harbormaster completed remote builds in B33039: Diff 46357.Dec 11 2024, 4:10 PM

ashoat requested review of this revision.Dec 11 2024, 4:10 PM

tomek accepted this revision.Dec 13 2024, 2:52 AM

This revision is now accepted and ready to land.Dec 13 2024, 2:52 AM

Closed by commit rCOMM77ed3c708135: [lib] Extract initialChatThreadItem (authored by ashoat). · Explain WhyDec 13 2024, 6:13 AM

This revision was automatically updated to reflect the committed changes.

Ashoat Tevosyan <ashoat@gmail.com> added a commit: rCOMM77ed3c708135: [lib] Extract initialChatThreadItem.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

chat-selectors.js

45 lines

Diff 46438

View Options

lib/selectors/chat-selectors.js

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines	OlmPersistSession persistSession = {
it->first,		it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()),		std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version};		it->second.version};

this->storeOlmPersistSession(persistSession);		this->storeOlmPersistSession(persistSession);
}		}
}		}

void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}

void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}

void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {		void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID);		this->setMetadata("current_user_id", userID);
}		}

std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {		std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id");		return this->getMetadata("current_user_id");
}		}

▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines

[lib] Extract initialChatThreadItemClosedPublicActions