Page MenuHomePhabricator

[native] Handle rendering "No messages" inside MessagePreview
Needs ReviewPublic

Authored by ashoat on Wed, Oct 30, 11:43 AM.
Tags
None
Referenced Files
F3105129: D13825.diff
Wed, Oct 30, 8:27 PM
F3104464: D13825.id45475.diff
Wed, Oct 30, 5:18 PM
F3104433: D13825.id.diff
Wed, Oct 30, 5:18 PM
F3104398: D13825.diff
Wed, Oct 30, 5:16 PM
Subscribers
None

Details

Reviewers
tomek
Summary

This matches behavior on web and makes a later diff a bit cleaner.

Depends on D13824

Test Plan

Flow, and tested in combination with the rest of the stack:

  1. Make sure membership operations (user joining / leaving) don't appear in MessagePreview
  2. Make sure reactions to the viewer's messages still appear in MessagePreview
  3. Make sure reactions to other user's messages don't appear in MessagePreview
  4. Test fresh login to thread with only one message in the last 14 days, which is a reaction to a non-viewer message. Make sure the reaction initially appears in MessagePreview, but then is replaced after more messages are fetched by the client

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage