Differential D14158

[lib] Deduplicate in getCandidateSidebarItemsForThreadList
ClosedPublic
Actions

Authored by ashoat on Dec 13 2024, 10:58 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

varun
will

Commits

rCOMMe5327d59bf9f: [lib] Deduplicate in getCandidateSidebarItemsForThreadList

Summary

I made a mistake in D14154: I forgot to deduplicate the "general" and unread results.

Depends on D14157

Test Plan

Confirm I no longer see duplicated candidate sidebar items

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 13 2024, 10:58 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 13 2024, 10:58 PM

I'll confirm relevant CI passes before landing

Harbormaster completed remote builds in B33115: Diff 46453.Dec 13 2024, 11:15 PM

varun accepted this revision.Dec 14 2024, 12:05 AM

This revision is now accepted and ready to land.Dec 14 2024, 12:05 AM

Closed by commit rCOMMe5327d59bf9f: [lib] Deduplicate in getCandidateSidebarItemsForThreadList. · Explain WhyDec 14 2024, 12:37 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe5327d59bf9f: [lib] Deduplicate in getCandidateSidebarItemsForThreadList.

Revision Contents
Changeset List

Path

Size

lib/

shared/

sidebar-item-utils.js

14 lines

Diff 46456

lib/shared/sidebar-item-utils.js

Loading...