[lib] Deduplicate in getCandidateSidebarItemsForThreadList
ClosedPublic
Actions

Authored by ashoat on Dec 13 2024, 2:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 19, 9:27 PM

	Unknown Object (File)
	Mar 11 2025, 4:13 PM

	Unknown Object (File)
	Feb 22 2025, 9:34 PM

	Unknown Object (File)
	Feb 22 2025, 9:34 PM

	Unknown Object (File)
	Feb 22 2025, 9:34 PM

	Unknown Object (File)
	Feb 22 2025, 9:34 PM

	Unknown Object (File)
	Feb 6 2025, 7:52 PM

	Unknown Object (File)
	Feb 6 2025, 7:41 PM

View All 49 Files

Subscribers

tomek

Details

Reviewers

varun
will

Commits

rCOMMe5327d59bf9f: [lib] Deduplicate in getCandidateSidebarItemsForThreadList

Summary

I made a mistake in D14154: I forgot to deduplicate the "general" and unread results.

Depends on D14157

Test Plan

Confirm I no longer see duplicated candidate sidebar items

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 13 2024, 2:58 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 13 2024, 2:58 PM

I'll confirm relevant CI passes before landing

Harbormaster completed remote builds in B33115: Diff 46453.Dec 13 2024, 3:15 PM

varun accepted this revision.Dec 13 2024, 4:05 PM

This revision is now accepted and ready to land.Dec 13 2024, 4:05 PM

Closed by commit rCOMMe5327d59bf9f: [lib] Deduplicate in getCandidateSidebarItemsForThreadList (authored by ashoat). · Explain WhyDec 13 2024, 4:37 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe5327d59bf9f: [lib] Deduplicate in getCandidateSidebarItemsForThreadList.

Revision Contents
Changeset List

Path

Size

lib/

shared/

sidebar-item-utils.js

14 lines

Diff 46456

View Options

lib/shared/sidebar-item-utils.js

[lib] Deduplicate in getCandidateSidebarItemsForThreadListClosedPublicActions