Paths

Table of Contentst

-
lib/selectors/
-
selectors/
-
chat-selectors.js

Differential D14157

[lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars
ClosedPublic
Actions

Authored by ashoat on Dec 13 2024, 2:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 11, 4:17 PM

	Unknown Object (File)
	Tue, Mar 11, 4:12 PM

	Unknown Object (File)
	Feb 22 2025, 9:34 PM

	Unknown Object (File)
	Feb 22 2025, 9:34 PM

	Unknown Object (File)
	Feb 22 2025, 9:34 PM

	Unknown Object (File)
	Feb 22 2025, 9:34 PM

	Unknown Object (File)
	Feb 20 2025, 10:26 AM

	Unknown Object (File)
	Feb 6 2025, 7:51 PM

View All 44 Files

Subscribers

Details

Reviewers

varun
will

Commits

rCOMM8266d4d872f1: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars

Summary

I made a mistake in D14154: I forgot that we should always consider the parent thread's timestamp in lastUpdatedTimeIncludingSidebars.

Depends on D14156

Test Plan

Confirm that we no longer see a massive performance regression

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 13 2024, 2:57 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 13 2024, 2:57 PM

I'll confirm relevant CI passes before landing

ashoat added a child revision: D14158: [lib] Deduplicate in getCandidateSidebarItemsForThreadList.Dec 13 2024, 2:58 PM

Harbormaster completed remote builds in B33114: Diff 46452.Dec 13 2024, 3:15 PM

varun accepted this revision.Dec 13 2024, 4:05 PM

This revision is now accepted and ready to land.Dec 13 2024, 4:05 PM

Closed by commit rCOMM8266d4d872f1: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars (authored by ashoat). · Explain WhyDec 13 2024, 4:37 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8266d4d872f1: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

chat-selectors.js

15 lines

Diff 46455

lib/selectors/chat-selectors.js

Loading...