Page MenuHomePhabricator

[lib] Use channel instead of channel/search Neynar endpoint
AcceptedPublic

Authored by ashoat on Wed, Nov 20, 6:44 AM.
Tags
None
Referenced Files
F3327122: D13979.id45903.diff
Wed, Nov 20, 8:17 AM
F3327098: D13979.id.diff
Wed, Nov 20, 8:17 AM
F3327063: D13979.diff
Wed, Nov 20, 8:16 AM
Subscribers

Details

Reviewers
varun
will
Summary

We're exceeding our compute unit allotment with Neynar: ENG-9930.

It's mostly the channel/search API. I'm guessing it's more expensive than the channel API, which has fewer capabilities.

Turns out we actually already have NeynarClient.fetchFarcasterChannelInfo, which calls the channel API. But we don't have any callsites to it anymore.

This diff replaces the code for NeynarClient.fetchFarcasterChannelByID with NeynarClient.fetchFarcasterChannelInfo, and subsequently removes the latter.

Depends on D13978

Test Plan

Tested that channel avatars still load on both web and native

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage