Page MenuHomePhabricator

[lib] Use channel instead of channel/search Neynar endpoint
ClosedPublic

Authored by ashoat on Nov 20 2024, 6:44 AM.
Tags
None
Referenced Files
F3985860: D13979.id.diff
Mon, Feb 3, 2:40 AM
Unknown Object (File)
Sat, Feb 1, 10:11 AM
Unknown Object (File)
Fri, Jan 17, 6:00 AM
Unknown Object (File)
Mon, Jan 13, 7:23 PM
Unknown Object (File)
Dec 27 2024, 3:07 AM
Unknown Object (File)
Dec 26 2024, 5:59 PM
Unknown Object (File)
Dec 25 2024, 2:47 PM
Unknown Object (File)
Dec 25 2024, 2:47 PM
Subscribers

Details

Summary

We're exceeding our compute unit allotment with Neynar: ENG-9930.

It's mostly the channel/search API. I'm guessing it's more expensive than the channel API, which has fewer capabilities.

Turns out we actually already have NeynarClient.fetchFarcasterChannelInfo, which calls the channel API. But we don't have any callsites to it anymore.

This diff replaces the code for NeynarClient.fetchFarcasterChannelByID with NeynarClient.fetchFarcasterChannelInfo, and subsequently removes the latter.

Depends on D13978

Test Plan

Tested that channel avatars still load on both web and native

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable