Paths

Table of Contentst

[comm-lib][blob] Add tags support to remove holders request payload
Needs ReviewPublic
Actions

Authored by bartek on Wed, Oct 9, 1:20 AM.

Details

Reviewers

kamil
varun
will

Summary

Expanded RemoveHoldersRequest to support either current payload format, or the new one that
removes holders that matches given tags. The new format is not supported yet, so added HTTP 501 Unimplemented response server side.

Depends on D13645

Test Plan

Unit tests for serialize/deserialize to make sure that existing request format is untouched.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Wed, Oct 9, 1:20 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Oct 9, 1:20 AM

bartek added a child revision: D13647: [blob] Add support for removing holders by tags.Wed, Oct 9, 1:22 AM

bartek mentioned this in D13648: [comm-lib][blob-client] Add support for removing holders by tags.Wed, Oct 9, 1:26 AM

Harbormaster completed remote builds in B32126: Diff 44996.Wed, Oct 9, 1:43 AM

bartek published this revision for review.Wed, Oct 9, 1:58 AM

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

http/

handlers/

holders.rs

9 lines

shared/

comm-lib/

src/

blob/

client.rs

2 lines

types.rs

90 lines

Diff 44996

View Options

services/blob/src/http/handlers/holders.rs

View Options

shared/comm-lib/src/blob/client.rs

View Options

shared/comm-lib/src/blob/types.rs

[comm-lib][blob] Add tags support to remove holders request payloadNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44996

services/blob/src/http/handlers/holders.rs

shared/comm-lib/src/blob/client.rs

shared/comm-lib/src/blob/types.rs

[comm-lib][blob] Add tags support to remove holders request payload
Needs ReviewPublic
Actions

Revision Contents
Changeset List