Page MenuHomePhabricator
Differential D13641

[identity] Add config for Blob service URL
ClosedPublic
Actions

Authored by bartek on Oct 9 2024, 1:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 22, 9:52 PM
Unknown Object (File)
Sat, Mar 15, 3:18 AM
Unknown Object (File)
Feb 17 2025, 10:34 AM
Unknown Object (File)
Feb 17 2025, 10:34 AM
Unknown Object (File)
Feb 17 2025, 10:34 AM
Unknown Object (File)
Feb 17 2025, 10:34 AM
Unknown Object (File)
Jan 29 2025, 11:54 AM
Unknown Object (File)
Jan 26 2025, 6:21 AM
View All 56 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
will
kamil
Commits
rCOMM450ee7a77ccd: [identity] Add config for Blob service URL
Summary

Similiar to D12972. Added config option and env var to specify Blob service endpoint in Identity service

Test Plan

Same as D12972
Cargo build. Played with clap CLI args in the terminal

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
src/
16 lines
4 lines

Diff 45156

View Options

services/identity/src/config.rs

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 Lines (actionCurrentUserInfo === null ||
(actionCurrentUserInfo && actionCurrentUserInfo.anonymous)) && (actionCurrentUserInfo && actionCurrentUserInfo.anonymous)) &&
preRequestUserState && preRequestUserState &&
(preRequestUserState.currentUserInfo?.id !== currentCurrentUserInfo.id || (preRequestUserState.currentUserInfo?.id !== currentCurrentUserInfo.id ||
preRequestUserState.commServicesAccessToken !== preRequestUserState.commServicesAccessToken !==
currentReduxState.commServicesAccessToken) currentReduxState.commServicesAccessToken)
); );
} }
// actionCurrentUserInfo can either be the CurrentUserInfo at the time the
// recovery began (preRequestUserInfo), or the CurrentUserInfo in the action.
// We expect that for a recovery they should be the same. The intention is to
// make sure that the CurrentUserInfo in Redux at the time this action is
// processed is the same as the user from whom the recovery was attempted. If
// that user has since logged out, we should ignore the result of the recovery.
const actionSourcesCheckedForInvalidSessionRecovery = new Set([
recoveryActionSources.cookieInvalidationResolutionAttempt,
recoveryActionSources.socketAuthErrorResolutionAttempt,
recoveryActionSources.appStartCookieLoggedInButInvalidRedux,
recoveryActionSources.appStartReduxLoggedInButInvalidCookie,
recoveryActionSources.refetchUserDataAfterAcknowledgment,
recoveryActionSources.socketNotLoggedIn,
]);
function invalidSessionRecovery( function invalidSessionRecovery(
currentReduxState: AppState, currentReduxState: AppState,
actionCurrentUserInfo: ?CurrentUserInfo, actionCurrentUserInfo: ?CurrentUserInfo,
authActionSource: ?AuthActionSource, authActionSource: ?AuthActionSource,
): boolean { ): boolean {
if ( if (
authActionSource !== !authActionSource ||
recoveryActionSources.cookieInvalidationResolutionAttempt && !actionSourcesCheckedForInvalidSessionRecovery.has(authActionSource)
authActionSource !== recoveryActionSources.socketAuthErrorResolutionAttempt
) { ) {
return false; return false;
} }
invariant( invariant(
actionCurrentUserInfo, actionCurrentUserInfo,
'currentUserInfo (preRequestUserInfo) should be defined when ' + 'actionCurrentUserInfo should be passed to invalidSessionRecovery for ' +
'COOKIE_INVALIDATION_RESOLUTION_ATTEMPT or ' + `${authActionSource} login`,
'SOCKET_AUTH_ERROR_RESOLUTION_ATTEMPT login is dispatched',
); );
if (actionCurrentUserInfo.anonymous) { if (actionCurrentUserInfo.anonymous) {
// It's not a session recovery if the CurrentUserInfo is anonymous // It's not a session recovery if the CurrentUserInfo is anonymous
return false; return false;
} }
return ( return (
!currentReduxState.dataLoaded || !currentReduxState.dataLoaded ||
currentReduxState.currentUserInfo?.id !== actionCurrentUserInfo.id currentReduxState.currentUserInfo?.id !== actionCurrentUserInfo.id
); );
} }
export { export {
invalidSessionDowngrade, invalidSessionDowngrade,
identityInvalidSessionDowngrade, identityInvalidSessionDowngrade,
invalidSessionRecovery, invalidSessionRecovery,
}; };
View Options

services/identity/src/constants.rs

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 Lines (actionCurrentUserInfo === null ||
(actionCurrentUserInfo && actionCurrentUserInfo.anonymous)) && (actionCurrentUserInfo && actionCurrentUserInfo.anonymous)) &&
preRequestUserState && preRequestUserState &&
(preRequestUserState.currentUserInfo?.id !== currentCurrentUserInfo.id || (preRequestUserState.currentUserInfo?.id !== currentCurrentUserInfo.id ||
preRequestUserState.commServicesAccessToken !== preRequestUserState.commServicesAccessToken !==
currentReduxState.commServicesAccessToken) currentReduxState.commServicesAccessToken)
); );
} }
// actionCurrentUserInfo can either be the CurrentUserInfo at the time the
// recovery began (preRequestUserInfo), or the CurrentUserInfo in the action.
// We expect that for a recovery they should be the same. The intention is to
// make sure that the CurrentUserInfo in Redux at the time this action is
// processed is the same as the user from whom the recovery was attempted. If
// that user has since logged out, we should ignore the result of the recovery.
const actionSourcesCheckedForInvalidSessionRecovery = new Set([
recoveryActionSources.cookieInvalidationResolutionAttempt,
recoveryActionSources.socketAuthErrorResolutionAttempt,
recoveryActionSources.appStartCookieLoggedInButInvalidRedux,
recoveryActionSources.appStartReduxLoggedInButInvalidCookie,
recoveryActionSources.refetchUserDataAfterAcknowledgment,
recoveryActionSources.socketNotLoggedIn,
]);
function invalidSessionRecovery( function invalidSessionRecovery(
currentReduxState: AppState, currentReduxState: AppState,
actionCurrentUserInfo: ?CurrentUserInfo, actionCurrentUserInfo: ?CurrentUserInfo,
authActionSource: ?AuthActionSource, authActionSource: ?AuthActionSource,
): boolean { ): boolean {
if ( if (
authActionSource !== !authActionSource ||
recoveryActionSources.cookieInvalidationResolutionAttempt && !actionSourcesCheckedForInvalidSessionRecovery.has(authActionSource)
authActionSource !== recoveryActionSources.socketAuthErrorResolutionAttempt
) { ) {
return false; return false;
} }
invariant( invariant(
actionCurrentUserInfo, actionCurrentUserInfo,
'currentUserInfo (preRequestUserInfo) should be defined when ' + 'actionCurrentUserInfo should be passed to invalidSessionRecovery for ' +
'COOKIE_INVALIDATION_RESOLUTION_ATTEMPT or ' + `${authActionSource} login`,
'SOCKET_AUTH_ERROR_RESOLUTION_ATTEMPT login is dispatched',
); );
if (actionCurrentUserInfo.anonymous) { if (actionCurrentUserInfo.anonymous) {
// It's not a session recovery if the CurrentUserInfo is anonymous // It's not a session recovery if the CurrentUserInfo is anonymous
return false; return false;
} }
return ( return (
!currentReduxState.dataLoaded || !currentReduxState.dataLoaded ||
currentReduxState.currentUserInfo?.id !== actionCurrentUserInfo.id currentReduxState.currentUserInfo?.id !== actionCurrentUserInfo.id
); );
} }
export { export {
invalidSessionDowngrade, invalidSessionDowngrade,
identityInvalidSessionDowngrade, identityInvalidSessionDowngrade,
invalidSessionRecovery, invalidSessionRecovery,
}; };