Page MenuHomePhabricator
Differential D13619

[blob] Add endpoint to query holders by prefix
DraftPublic
Actions

Authored by bartek on Oct 4 2024, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 15 2025, 3:18 AM
Unknown Object (File)
Mar 9 2025, 12:18 PM
Unknown Object (File)
Mar 9 2025, 1:53 AM
Unknown Object (File)
Mar 8 2025, 6:19 PM
Unknown Object (File)
Mar 7 2025, 2:18 PM
Unknown Object (File)
Mar 6 2025, 10:26 PM
Unknown Object (File)
Mar 6 2025, 3:52 PM
Unknown Object (File)
Mar 3 2025, 11:45 PM
View All 74 Files
Subscribers
ashoat
tomek
This is a draft revision that has not yet been submitted for review.

Details

Reviewers
kamil
varun
will
Summary

To make Blob API consistent and be closer to REST principles. It is preparation for ENG-306
Added the GET /holders?prefix=some_prefix_here that allows querying holders by prefix.

Depends on D13618

Test Plan
  • Added some holders with and without prefixes
  • Used Postman to call this endpoint and verified that correct items are returned
  • Verified that the function is only callable with a valid service-to-service token

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
blob/
src/
http/
handlers/
18 lines
1 line
shared/
comm-lib/
src/
blob/
10 lines

Diff 45052

View Options

services/blob/src/http/handlers/holders.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { useAddUsersPermissions } from 'lib/permissions/add-users-permissions.js';
import { useUserSearchIndex } from 'lib/selectors/nav-selectors.js'; import { useUserSearchIndex } from 'lib/selectors/nav-selectors.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors.js'; import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import { import { roleIsAdminRole } from 'lib/shared/thread-utils.js';
roleIsAdminRole,
useThreadHasPermission,
} from 'lib/shared/thread-utils.js';
import type { RelativeMemberInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { RelativeMemberInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { threadTypeIsCommunityRoot } from 'lib/types/thread-types-enum.js';
import { useRolesFromCommunityThreadInfo } from 'lib/utils/role-utils.js'; import { useRolesFromCommunityThreadInfo } from 'lib/utils/role-utils.js';
import { AddMembersModal } from './add-members-modal.react.js'; import { AddMembersModal } from './add-members-modal.react.js';
import ThreadMembersList from './members-list.react.js'; import ThreadMembersList from './members-list.react.js';
import css from './members-modal.css'; import css from './members-modal.css';
import Button from '../../../components/button.react.js'; import Button from '../../../components/button.react.js';
import Tabs, { type TabData } from '../../../components/tabs.react.js'; import Tabs, { type TabData } from '../../../components/tabs.react.js';
import ManageInviteLinksModal from '../../../invite-links/manage-invite-links-modal.react.js'; import ManageInviteLinksModal from '../../../invite-links/manage-invite-links-modal.react.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines const renderModalContent = React.useCallback(
), ),
[threadID], [threadID],
); );
const { pushModal, popModal } = useModalContext(); const { pushModal, popModal } = useModalContext();
const threadInfo = useSelector(state => threadInfoSelector(state)[threadID]); const threadInfo = useSelector(state => threadInfoSelector(state)[threadID]);
const inviteLink = useSelector(primaryInviteLinksSelector)[threadID]; const { inviteLink, canManageLinks, canAddMembers, isCommunityRoot } =
const canManageLinks = useThreadHasPermission( useAddUsersPermissions(threadInfo);
threadInfo,
threadPermissions.MANAGE_INVITE_LINKS,
);
const isCommunityRoot = threadTypeIsCommunityRoot(threadInfo.type);
const onClickAddMembers = React.useCallback(() => { const onClickAddMembers = React.useCallback(() => {
if (!isCommunityRoot) { if (!isCommunityRoot) {
pushModal(<AddMembersModal onClose={popModal} threadID={threadID} />); pushModal(<AddMembersModal onClose={popModal} threadID={threadID} />);
} else if (inviteLink) { } else if (inviteLink) {
pushModal(<ViewInviteLinkModal inviteLink={inviteLink} />); pushModal(<ViewInviteLinkModal inviteLink={inviteLink} />);
} else if (canManageLinks) { } else if (canManageLinks) {
pushModal(<ManageInviteLinksModal communityID={threadID} />); pushModal(<ManageInviteLinksModal communityID={threadID} />);
} }
}, [ }, [
canManageLinks, canManageLinks,
inviteLink, inviteLink,
isCommunityRoot, isCommunityRoot,
popModal, popModal,
pushModal, pushModal,
threadID, threadID,
]); ]);
const canAddMembersViaInviteLink =
isCommunityRoot && (inviteLink || canManageLinks);
const hasAddMembersPermission = useThreadHasPermission(
threadInfo,
threadPermissions.ADD_MEMBERS,
);
const canAddMembersManually = hasAddMembersPermission && !isCommunityRoot;
const canAddMembers = canAddMembersManually || canAddMembersViaInviteLink;
const addMembersButton = React.useMemo(() => { const addMembersButton = React.useMemo(() => {
if (!canAddMembers) { if (!canAddMembers) {
return null; return null;
} }
return ( return (
<div className={css.addNewMembers}> <div className={css.addNewMembers}>
<Button variant="filled" onClick={onClickAddMembers}> <Button variant="filled" onClick={onClickAddMembers}>
Add members Add members
Show All 19 Lines
View Options

services/blob/src/http/mod.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { useAddUsersPermissions } from 'lib/permissions/add-users-permissions.js';
import { useUserSearchIndex } from 'lib/selectors/nav-selectors.js'; import { useUserSearchIndex } from 'lib/selectors/nav-selectors.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors.js'; import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import { import { roleIsAdminRole } from 'lib/shared/thread-utils.js';
roleIsAdminRole,
useThreadHasPermission,
} from 'lib/shared/thread-utils.js';
import type { RelativeMemberInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { RelativeMemberInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { threadTypeIsCommunityRoot } from 'lib/types/thread-types-enum.js';
import { useRolesFromCommunityThreadInfo } from 'lib/utils/role-utils.js'; import { useRolesFromCommunityThreadInfo } from 'lib/utils/role-utils.js';
import { AddMembersModal } from './add-members-modal.react.js'; import { AddMembersModal } from './add-members-modal.react.js';
import ThreadMembersList from './members-list.react.js'; import ThreadMembersList from './members-list.react.js';
import css from './members-modal.css'; import css from './members-modal.css';
import Button from '../../../components/button.react.js'; import Button from '../../../components/button.react.js';
import Tabs, { type TabData } from '../../../components/tabs.react.js'; import Tabs, { type TabData } from '../../../components/tabs.react.js';
import ManageInviteLinksModal from '../../../invite-links/manage-invite-links-modal.react.js'; import ManageInviteLinksModal from '../../../invite-links/manage-invite-links-modal.react.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines const renderModalContent = React.useCallback(
), ),
[threadID], [threadID],
); );
const { pushModal, popModal } = useModalContext(); const { pushModal, popModal } = useModalContext();
const threadInfo = useSelector(state => threadInfoSelector(state)[threadID]); const threadInfo = useSelector(state => threadInfoSelector(state)[threadID]);
const inviteLink = useSelector(primaryInviteLinksSelector)[threadID]; const { inviteLink, canManageLinks, canAddMembers, isCommunityRoot } =
const canManageLinks = useThreadHasPermission( useAddUsersPermissions(threadInfo);
threadInfo,
threadPermissions.MANAGE_INVITE_LINKS,
);
const isCommunityRoot = threadTypeIsCommunityRoot(threadInfo.type);
const onClickAddMembers = React.useCallback(() => { const onClickAddMembers = React.useCallback(() => {
if (!isCommunityRoot) { if (!isCommunityRoot) {
pushModal(<AddMembersModal onClose={popModal} threadID={threadID} />); pushModal(<AddMembersModal onClose={popModal} threadID={threadID} />);
} else if (inviteLink) { } else if (inviteLink) {
pushModal(<ViewInviteLinkModal inviteLink={inviteLink} />); pushModal(<ViewInviteLinkModal inviteLink={inviteLink} />);
} else if (canManageLinks) { } else if (canManageLinks) {
pushModal(<ManageInviteLinksModal communityID={threadID} />); pushModal(<ManageInviteLinksModal communityID={threadID} />);
} }
}, [ }, [
canManageLinks, canManageLinks,
inviteLink, inviteLink,
isCommunityRoot, isCommunityRoot,
popModal, popModal,
pushModal, pushModal,
threadID, threadID,
]); ]);
const canAddMembersViaInviteLink =
isCommunityRoot && (inviteLink || canManageLinks);
const hasAddMembersPermission = useThreadHasPermission(
threadInfo,
threadPermissions.ADD_MEMBERS,
);
const canAddMembersManually = hasAddMembersPermission && !isCommunityRoot;
const canAddMembers = canAddMembersManually || canAddMembersViaInviteLink;
const addMembersButton = React.useMemo(() => { const addMembersButton = React.useMemo(() => {
if (!canAddMembers) { if (!canAddMembers) {
return null; return null;
} }
return ( return (
<div className={css.addNewMembers}> <div className={css.addNewMembers}>
<Button variant="filled" onClick={onClickAddMembers}> <Button variant="filled" onClick={onClickAddMembers}>
Add members Add members
Show All 19 Lines
View Options

shared/comm-lib/src/blob/types.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { useModalContext } from 'lib/components/modal-provider.react.js'; import { useModalContext } from 'lib/components/modal-provider.react.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { useAddUsersPermissions } from 'lib/permissions/add-users-permissions.js';
import { useUserSearchIndex } from 'lib/selectors/nav-selectors.js'; import { useUserSearchIndex } from 'lib/selectors/nav-selectors.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors.js'; import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import { import { roleIsAdminRole } from 'lib/shared/thread-utils.js';
roleIsAdminRole,
useThreadHasPermission,
} from 'lib/shared/thread-utils.js';
import type { RelativeMemberInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { RelativeMemberInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { threadTypeIsCommunityRoot } from 'lib/types/thread-types-enum.js';
import { useRolesFromCommunityThreadInfo } from 'lib/utils/role-utils.js'; import { useRolesFromCommunityThreadInfo } from 'lib/utils/role-utils.js';
import { AddMembersModal } from './add-members-modal.react.js'; import { AddMembersModal } from './add-members-modal.react.js';
import ThreadMembersList from './members-list.react.js'; import ThreadMembersList from './members-list.react.js';
import css from './members-modal.css'; import css from './members-modal.css';
import Button from '../../../components/button.react.js'; import Button from '../../../components/button.react.js';
import Tabs, { type TabData } from '../../../components/tabs.react.js'; import Tabs, { type TabData } from '../../../components/tabs.react.js';
import ManageInviteLinksModal from '../../../invite-links/manage-invite-links-modal.react.js'; import ManageInviteLinksModal from '../../../invite-links/manage-invite-links-modal.react.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines const renderModalContent = React.useCallback(
), ),
[threadID], [threadID],
); );
const { pushModal, popModal } = useModalContext(); const { pushModal, popModal } = useModalContext();
const threadInfo = useSelector(state => threadInfoSelector(state)[threadID]); const threadInfo = useSelector(state => threadInfoSelector(state)[threadID]);
const inviteLink = useSelector(primaryInviteLinksSelector)[threadID]; const { inviteLink, canManageLinks, canAddMembers, isCommunityRoot } =
const canManageLinks = useThreadHasPermission( useAddUsersPermissions(threadInfo);
threadInfo,
threadPermissions.MANAGE_INVITE_LINKS,
);
const isCommunityRoot = threadTypeIsCommunityRoot(threadInfo.type);
const onClickAddMembers = React.useCallback(() => { const onClickAddMembers = React.useCallback(() => {
if (!isCommunityRoot) { if (!isCommunityRoot) {
pushModal(<AddMembersModal onClose={popModal} threadID={threadID} />); pushModal(<AddMembersModal onClose={popModal} threadID={threadID} />);
} else if (inviteLink) { } else if (inviteLink) {
pushModal(<ViewInviteLinkModal inviteLink={inviteLink} />); pushModal(<ViewInviteLinkModal inviteLink={inviteLink} />);
} else if (canManageLinks) { } else if (canManageLinks) {
pushModal(<ManageInviteLinksModal communityID={threadID} />); pushModal(<ManageInviteLinksModal communityID={threadID} />);
} }
}, [ }, [
canManageLinks, canManageLinks,
inviteLink, inviteLink,
isCommunityRoot, isCommunityRoot,
popModal, popModal,
pushModal, pushModal,
threadID, threadID,
]); ]);
const canAddMembersViaInviteLink =
isCommunityRoot && (inviteLink || canManageLinks);
const hasAddMembersPermission = useThreadHasPermission(
threadInfo,
threadPermissions.ADD_MEMBERS,
);
const canAddMembersManually = hasAddMembersPermission && !isCommunityRoot;
const canAddMembers = canAddMembersManually || canAddMembersViaInviteLink;
const addMembersButton = React.useMemo(() => { const addMembersButton = React.useMemo(() => {
if (!canAddMembers) { if (!canAddMembers) {
return null; return null;
} }
return ( return (
<div className={css.addNewMembers}> <div className={css.addNewMembers}>
<Button variant="filled" onClick={onClickAddMembers}> <Button variant="filled" onClick={onClickAddMembers}>
Add members Add members
Show All 19 Lines