Paths

Table of Contentst

Differential D13619

[blob] Add endpoint to query holders by prefix
DraftPublic
Actions

Authored by bartek on Oct 4 2024, 6:48 PM.

Tags

None

Referenced Files

None

Subscribers

This is a draft revision that has not yet been submitted for review.

Details

Reviewers

kamil
varun
will

Summary

To make Blob API consistent and be closer to REST principles. It is preparation for ENG-306
Added the GET /holders?prefix=some_prefix_here that allows querying holders by prefix.

Depends on D13618

Test Plan

Added some holders with and without prefixes
Used Postman to call this endpoint and verified that correct items are returned
Verified that the function is only callable with a valid service-to-service token

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Oct 4 2024, 6:48 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 4 2024, 6:48 PM

Harbormaster completed remote builds in B32081: Diff 44914.Oct 4 2024, 7:14 PM

bartek edited the summary of this revision. (Show Details)Oct 9 2024, 9:34 AM

Rebase

bartek added a child revision: D13658: [comm-lib] Add query_holders_by_prefix to Blob client.Oct 9 2024, 9:38 AM

Harbormaster completed remote builds in B32138: Diff 45008.Oct 9 2024, 9:58 AM

Rebase

Harbormaster failed remote builds in B32177: Diff 45052!Oct 10 2024, 12:40 PM

This is still useful for https://linear.app/comm/issue/ENG-306/handle-lost-database-in-services-using-the-blob-service

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

http/

handlers/

18 lines

1 line

shared/

comm-lib/

src/

blob/

10 lines

Diff 45052

services/blob/src/http/handlers/holders.rs

Loading...

services/blob/src/http/mod.rs

Loading...

shared/comm-lib/src/blob/types.rs

Loading...