Paths

Table of Contentst

Differential D13615

[blob] Store indexable tag in DDB for holders
ClosedPublic
Actions

Authored by bartek on Oct 4 2024, 11:39 AM.

Tags

None

Referenced Files

	F3327387: D13615.id45072.diff
	Wed, Nov 20, 9:30 AM

	F3327384: D13615.id45083.diff
	Wed, Nov 20, 9:30 AM

	Unknown Object (File)
	Fri, Nov 15, 3:27 PM

	Unknown Object (File)
	Sat, Nov 9, 11:39 PM

	Unknown Object (File)
	Wed, Nov 6, 11:33 PM

	Unknown Object (File)
	Thu, Oct 31, 10:00 PM

	Unknown Object (File)
	Wed, Oct 30, 5:11 PM

	Unknown Object (File)
	Wed, Oct 30, 5:26 AM

View All 44 Files

Subscribers

Details

Reviewers

kamil
varun
will

Commits

rCOMMb069c41703dd: [blob] Store indexable tag in DDB for holders

Summary

Part of ENG-9367.
It's described in the issue why this is needed.

Test Plan

Unit tests
Added some holders with prefixes. Verified that prefix is stored in DDB

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Oct 4 2024, 11:39 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 4 2024, 11:39 AM

bartek added a child revision: D13616: [terraform] Add index for holder prefixes.Oct 4 2024, 11:42 AM

Harbormaster completed remote builds in B32077: Diff 44909.Oct 4 2024, 11:57 AM

bartek published this revision for review.Oct 6 2024, 11:51 PM

varun accepted this revision.Oct 7 2024, 8:48 PM

varun added inline comments.

services/blob/src/database/client.rs
444 ↗	(On Diff #44909)	when is `tags` not an empty slice?

This revision is now accepted and ready to land.Oct 7 2024, 8:48 PM

bartek added inline comments.Oct 8 2024, 12:57 AM

services/blob/src/database/client.rs
444 ↗	(On Diff #44909)	Now it's always empty, but I've prepared this code to easily add support for ENG-306 in the future

kamil accepted this revision.Oct 10 2024, 1:53 AM

kamil added inline comments.

services/blob/src/database/client.rs
444 ↗	(On Diff #44909)	as discussed offline - worth documenting the design with code comments, especially until ENG-306 is implemented, in the current state this could be confusing

Add appropriate comment

Harbormaster completed remote builds in B32189: Diff 45072.Oct 10 2024, 11:58 AM

Closed by commit rCOMMb069c41703dd: [blob] Store indexable tag in DDB for holders (authored by bartek). · Explain WhyOct 10 2024, 2:06 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMb069c41703dd: [blob] Store indexable tag in DDB for holders.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

1 line

database/

64 lines

Diff 45083

services/blob/src/constants.rs

Loading...

services/blob/src/database/client.rs

Loading...