Details

Reviewers

kamil
varun
will

Commits

rCOMMe31290555a24: [comm-lib] Add remove_multiple_holders to Blob client

Summary

We're missing functions for batch holders endpoints in BlobServiceClient.
Started with the one that's needed for server-side holder cleanup

Depends on D13617

Test Plan

Started Blob service. Created a few holders.
Created a dummy test that calls this function.
Ran cargo test and verified that these holders were now removed from DDB

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Oct 9 2024, 8:15 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 9 2024, 8:15 AM

bartek added a child revision: D13645: [comm-lib][blob-client] Extract error handling logic.Oct 9 2024, 8:17 AM

bartek mentioned this in D13648: [comm-lib][blob-client] Add support for removing holders by tags.Oct 9 2024, 8:26 AM

Harbormaster completed remote builds in B32124: Diff 44994.Oct 9 2024, 8:33 AM

bartek published this revision for review.Oct 9 2024, 8:55 AM

kamil accepted this revision.Oct 10 2024, 9:02 AM

kamil added inline comments.

shared/comm-lib/src/blob/client.rs
263 ↗	(On Diff #44994)	given the name for single edpoint, shouldn't this be `revoke_multiple_holders`?

This revision is now accepted and ready to land.Oct 10 2024, 9:02 AM

Closed by commit rCOMMe31290555a24: [comm-lib] Add remove_multiple_holders to Blob client. · Explain WhyOct 14 2024, 2:20 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMe31290555a24: [comm-lib] Add remove_multiple_holders to Blob client.

bartek mentioned this in rCOMMb5d7583ea75d: [comm-lib][blob-client] Add support for removing holders by tags.

ashoat added inline comments.Oct 14 2024, 7:09 PM

shared/comm-lib/src/blob/client.rs
263 ↗	(On Diff #44994)	It seems like this feedback wasn't addressed

bartek mentioned this in D14676: [blob-client] Add method to assign multiple holders.May 9 2025, 11:40 AM

bartek mentioned this in rCOMMc36577e18164: [blob-client] Add method to assign multiple holders.May 16 2025, 1:35 PM

[comm-lib] Add remove_multiple_holders to Blob client
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 45159

shared/comm-lib/src/blob/client.rs

shared/comm-lib/src/blob/types.rs

[comm-lib] Add remove_multiple_holders to Blob clientClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45159

shared/comm-lib/src/blob/client.rs

shared/comm-lib/src/blob/types.rs

[comm-lib] Add remove_multiple_holders to Blob client
ClosedPublic
Actions

Revision Contents
Changeset List