Differential D14676

[blob-client] Add method to assign multiple holders
ClosedPublic
Actions

Authored by bartek on May 9 2025, 11:40 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMMc36577e18164: [blob-client] Add method to assign multiple holders

Summary

Similiar to D13644 - that diff added a function to remove multiple holders,
this one adds a counterpart to the other multiple-holder endpoint.

Depends on D14672

Test Plan

tested on staging along with backup changes.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 9 2025, 11:40 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 9 2025, 11:40 AM

Harbormaster failed remote builds in B34133: Diff 48006!May 9 2025, 11:53 AM

Rebase

bartek added a child revision: D14680: [comm-lib] Move exponential backoff helper to a separate mod.May 12 2025, 8:49 AM

Harbormaster completed remote builds in B34141: Diff 48028.May 12 2025, 9:07 AM

bartek published this revision for review.May 12 2025, 9:42 AM

bartek added inline comments.

shared/comm-lib/src/blob/client.rs
310–327 ↗	(On Diff #48028)	These are a bit unrelated. Early exits were added to the new function, and this func was missing them too.
shared/comm-lib/src/blob/types.rs
104–110 ↗	(On Diff #48028)	Alternative syntax, perhaps cleaner .filter(\|result\| !result.success) .map(\|result\| result.request.clone()) They behave the same under the hood.

bartek added a parent revision: D14674: [backup] Return backup size and timestamp in LatestBackupInfo.May 13 2025, 3:05 PM

kamil accepted this revision.May 14 2025, 10:36 AM

kamil added inline comments.

shared/comm-lib/src/blob/client.rs
246 ↗	(On Diff #48028)	typo
shared/comm-lib/src/blob/types.rs
104–110 ↗	(On Diff #48028)	I prefer the suggested one

This revision is now accepted and ready to land.May 14 2025, 10:36 AM

Use alternative syntax

Harbormaster completed remote builds in B34174: Diff 48083.May 15 2025, 12:40 PM

Closed by commit rCOMMc36577e18164: [blob-client] Add method to assign multiple holders. · Explain WhyMay 16 2025, 1:35 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMc36577e18164: [blob-client] Add method to assign multiple holders.

Revision Contents
Changeset List

Path

Size

shared/

comm-lib/

src/

blob/

69 lines

11 lines

Diff 48102

shared/comm-lib/src/blob/client.rs

Loading...

shared/comm-lib/src/blob/types.rs

Loading...